You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by nchammas <gi...@git.apache.org> on 2016/07/29 20:15:31 UTC

[GitHub] spark pull request #14408: [SPARK-16772] Restore "datatype string" to Python...

GitHub user nchammas opened a pull request:

    https://github.com/apache/spark/pull/14408

    [SPARK-16772] Restore "datatype string" to Python API docstrings

    ## What changes were proposed in this pull request?
    
    This PR corrects [an error made in an earlier PR](https://github.com/apache/spark/pull/14393/files#r72843069).
    
    
    ## How was this patch tested?
    
    ```sh
    $ ./dev/lint-python 
    PEP8 checks passed.
    rm -rf _build/*
    pydoc checks passed.
    ```
    
    I also built the docs and confirmed that they looked good in my browser.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nchammas/spark SPARK-16772

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/14408.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14408
    
----
commit 58f388533a6300e49de0d239d3ad0f7d17afca50
Author: Nicholas Chammas <ni...@gmail.com>
Date:   2016-07-29T20:03:50Z

    restore "datatype string"

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #14408: [SPARK-16772] [Python] [Docs] Restore "datatype string" ...

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:

    https://github.com/apache/spark/pull/14408
  
    Merging in master/2.0.
     Thanks.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #14408: [SPARK-16772] [Python] [Docs] Restore "datatype s...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/14408


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #14408: [SPARK-16772] Restore "datatype string" to Python API do...

Posted by nchammas <gi...@git.apache.org>.
Github user nchammas commented on the issue:

    https://github.com/apache/spark/pull/14408
  
    cc @rxin


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org