You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "the-other-tim-brown (via GitHub)" <gi...@apache.org> on 2024/12/03 23:49:04 UTC
[PR] [MINOR] Pass in engine context from StreamSync to dedupe [hudi]
the-other-tim-brown opened a new pull request, #12417:
URL: https://github.com/apache/hudi/pull/12417
### Change Logs
- Pass in the existing HoodieEngineContext instead of creating a new one when calling dedupe from the StreamSync
- Add basic unit test to ensure no wiring breaks here
### Impact
- Uses a consistent engine context
### Risk level (write none, low medium or high below)
None
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none"._
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Pass in engine context from StreamSync to dedupe [hudi]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on code in PR #12417:
URL: https://github.com/apache/hudi/pull/12417#discussion_r1869637309
##########
hudi-spark-datasource/hudi-spark-common/src/main/java/org/apache/hudi/DataSourceUtils.java:
##########
@@ -279,15 +279,15 @@ public static HoodieRecord createHoodieRecord(GenericRecord gr, HoodieKey hKey,
/**
* Drop records already present in the dataset.
*
- * @param jssc JavaSparkContext
+ * @param engineContext the spark engine context
* @param incomingHoodieRecords HoodieRecords to deduplicate
* @param writeConfig HoodieWriteConfig
*/
@SuppressWarnings("unchecked")
- public static JavaRDD<HoodieRecord> dropDuplicates(JavaSparkContext jssc, JavaRDD<HoodieRecord> incomingHoodieRecords,
+ public static JavaRDD<HoodieRecord> dropDuplicates(HoodieSparkEngineContext engineContext, JavaRDD<HoodieRecord> incomingHoodieRecords,
HoodieWriteConfig writeConfig) {
try {
- SparkRDDReadClient client = new SparkRDDReadClient<>(new HoodieSparkEngineContext(jssc), writeConfig);
+ SparkRDDReadClient client = new SparkRDDReadClient<>(engineContext, writeConfig);
Review Comment:
it's just cosmetic, we use a custom extension of the engine context to add more context to the names of steps so we can more easily debug when looking at the spark UI or history server UI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Pass in engine context from StreamSync to dedupe [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12417:
URL: https://github.com/apache/hudi/pull/12417#issuecomment-2515819755
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9508749342baeb0a77586efa51b2d10a471eaa17",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9508749342baeb0a77586efa51b2d10a471eaa17",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9508749342baeb0a77586efa51b2d10a471eaa17 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Pass in engine context from StreamSync to dedupe [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #12417:
URL: https://github.com/apache/hudi/pull/12417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Pass in engine context from StreamSync to dedupe [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12417:
URL: https://github.com/apache/hudi/pull/12417#issuecomment-2515821439
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9508749342baeb0a77586efa51b2d10a471eaa17",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2249",
"triggerID" : "9508749342baeb0a77586efa51b2d10a471eaa17",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9508749342baeb0a77586efa51b2d10a471eaa17 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2249)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Pass in engine context from StreamSync to dedupe [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #12417:
URL: https://github.com/apache/hudi/pull/12417#issuecomment-2515939186
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9508749342baeb0a77586efa51b2d10a471eaa17",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2249",
"triggerID" : "9508749342baeb0a77586efa51b2d10a471eaa17",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9508749342baeb0a77586efa51b2d10a471eaa17 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=2249)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] Pass in engine context from StreamSync to dedupe [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #12417:
URL: https://github.com/apache/hudi/pull/12417#discussion_r1868761782
##########
hudi-spark-datasource/hudi-spark-common/src/main/java/org/apache/hudi/DataSourceUtils.java:
##########
@@ -279,15 +279,15 @@ public static HoodieRecord createHoodieRecord(GenericRecord gr, HoodieKey hKey,
/**
* Drop records already present in the dataset.
*
- * @param jssc JavaSparkContext
+ * @param engineContext the spark engine context
* @param incomingHoodieRecords HoodieRecords to deduplicate
* @param writeConfig HoodieWriteConfig
*/
@SuppressWarnings("unchecked")
- public static JavaRDD<HoodieRecord> dropDuplicates(JavaSparkContext jssc, JavaRDD<HoodieRecord> incomingHoodieRecords,
+ public static JavaRDD<HoodieRecord> dropDuplicates(HoodieSparkEngineContext engineContext, JavaRDD<HoodieRecord> incomingHoodieRecords,
HoodieWriteConfig writeConfig) {
try {
- SparkRDDReadClient client = new SparkRDDReadClient<>(new HoodieSparkEngineContext(jssc), writeConfig);
+ SparkRDDReadClient client = new SparkRDDReadClient<>(engineContext, writeConfig);
Review Comment:
what's the gains?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org