You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/01/09 07:02:42 UTC
[GitHub] [netbeans] JaroslavTulach commented on pull request #2651: Mentlicher/backport to122
JaroslavTulach commented on pull request #2651:
URL: https://github.com/apache/netbeans/pull/2651#issuecomment-757107931
This is my fix:
```diff
$ git show
commit 1719e5fbd4ccbc0d45ed0b8950fb0ec57517f664 (HEAD -> MartinBackport)
Author: Jaroslav Tulach <ja...@oracle.com>
Date: Sat Jan 9 07:47:09 2021 +0100
Implementation dependency is currently necessary in order to implement IndexingAware
diff --git a/java/java.lsp.server/nbproject/project.xml b/java/java.lsp.server/nbproject/project.xml
index f2d5ff816335..9488dff9dd6e 100644
--- a/java/java.lsp.server/nbproject/project.xml
+++ b/java/java.lsp.server/nbproject/project.xml
@@ -256,7 +256,7 @@
<build-prerequisite/>
<compile-dependency/>
<run-dependency>
- <specification-version>9.13</specification-version>
+ <implementation-version/>
</run-dependency>
</dependency>
<dependency>
diff --git a/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/TextDocumentServiceImpl.java b/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/TextDocumentServiceImpl.java
index f57f3e7288a0..5b4335ac9c2d 100644
--- a/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/TextDocumentServiceImpl.java
+++ b/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/TextDocumentServiceImpl.java
@@ -120,6 +120,8 @@ import org.eclipse.lsp4j.jsonrpc.messages.Either;
import org.eclipse.lsp4j.services.LanguageClient;
import org.eclipse.lsp4j.services.LanguageClientAware;
import org.eclipse.lsp4j.services.TextDocumentService;
+import org.netbeans.api.editor.document.LineDocument;
+import org.netbeans.api.editor.document.LineDocumentUtils;
import org.netbeans.api.java.lexer.JavaTokenId;
import org.netbeans.api.java.source.CompilationController;
import org.netbeans.api.java.source.CompilationInfo;
```
I don't like the implementation dependency, but we can hardly do any better by Monday. With the above fix the `ant build` succeeds on my machine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists