You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2018/09/15 17:25:54 UTC
[text] Refactor magic string.
Repository: commons-text
Updated Branches:
refs/heads/master 0a8d0cf97 -> d72b390c2
Refactor magic string.
Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-text/commit/d72b390c
Tree: http://git-wip-us.apache.org/repos/asf/commons-text/tree/d72b390c
Diff: http://git-wip-us.apache.org/repos/asf/commons-text/diff/d72b390c
Branch: refs/heads/master
Commit: d72b390c27c4dac9989c74628fe75bc20e561962
Parents: 0a8d0cf
Author: Gary Gregory <gg...@rocketsoftware.com>
Authored: Sat Sep 15 11:25:52 2018 -0600
Committer: Gary Gregory <gg...@rocketsoftware.com>
Committed: Sat Sep 15 11:25:52 2018 -0600
----------------------------------------------------------------------
.../org/apache/commons/text/lookup/AbstractStringLookup.java | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-text/blob/d72b390c/src/main/java/org/apache/commons/text/lookup/AbstractStringLookup.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/text/lookup/AbstractStringLookup.java b/src/main/java/org/apache/commons/text/lookup/AbstractStringLookup.java
index f265bf7..6ded43e 100644
--- a/src/main/java/org/apache/commons/text/lookup/AbstractStringLookup.java
+++ b/src/main/java/org/apache/commons/text/lookup/AbstractStringLookup.java
@@ -24,6 +24,7 @@ package org.apache.commons.text.lookup;
*/
abstract class AbstractStringLookup implements StringLookup {
+ private static final String EMPTY = "";
protected static final char SPLIT_CH = ':';
protected static final String SPLIT_STR = String.valueOf(SPLIT_CH);
@@ -38,7 +39,7 @@ abstract class AbstractStringLookup implements StringLookup {
*/
protected String substringAfter(final String value, final char ch) {
final int indexOf = value.indexOf(ch);
- return indexOf > -1 ? value.substring(indexOf + 1) : "";
+ return indexOf > -1 ? value.substring(indexOf + 1) : EMPTY;
}
/**
@@ -52,6 +53,6 @@ abstract class AbstractStringLookup implements StringLookup {
*/
protected String substringAfter(final String value, final String str) {
final int indexOf = value.indexOf(str);
- return indexOf > -1 ? value.substring(indexOf + str.length()) : "";
+ return indexOf > -1 ? value.substring(indexOf + str.length()) : EMPTY;
}
}