You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by shijinkui <gi...@git.apache.org> on 2014/10/03 16:57:34 UTC
[GitHub] spark pull request: code style format
GitHub user shijinkui opened a pull request:
https://github.com/apache/spark/pull/2643
code style format
code style format
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shijinkui/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2643.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2643
----
commit e00f13a554fb4a95996250e6cd65403fcc20b6e2
Author: shijinkui <sh...@163.com>
Date: 2014-09-29T05:34:02Z
code style format
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: code style format
Posted by shijinkui <gi...@git.apache.org>.
Github user shijinkui commented on the pull request:
https://github.com/apache/spark/pull/2643#issuecomment-58187162
in the intellij IDEA, too much yellow tips to fix.
after changing, the code looks better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: code style format
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2643#issuecomment-57808284
Some changes here make lines longer than 100 characters, which contradicts the scalastyle rules for the project. I am not sure that moving comments around to a previous line is an improvement. The rest looks fairly trivial if a little positive; is it worth changing? It would need a JIRA in any event.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: code style format
Posted by shijinkui <gi...@git.apache.org>.
Github user shijinkui closed the pull request at:
https://github.com/apache/spark/pull/2643
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org