You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/03 03:10:32 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #24519:
[SPARK-27612][PYTHON] Use Python's default protocol instead of highest
protocol
HyukjinKwon commented on a change in pull request #24519: [SPARK-27612][PYTHON] Use Python's default protocol instead of highest protocol
URL: https://github.com/apache/spark/pull/24519#discussion_r280654791
##########
File path: python/pyspark/serializers.py
##########
@@ -62,11 +62,12 @@
if sys.version < '3':
import cPickle as pickle
from itertools import izip as zip, imap as map
+ pickle_protocol = 2
else:
import pickle
basestring = unicode = str
xrange = range
-pickle_protocol = pickle.HIGHEST_PROTOCOL
+ pickle_protocol = 3
Review comment:
We can use `pickle.DEFAULT_PROTOCOL` too but let me stick with constant since seems protocol 4 has this bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org