[GitHub] [beam] ibzib edited a comment on pull request #13798: [BEAM-9541] Push all docker images from RC instead of hard-coding them.

[GitBox <gi...@apache.org>]

ibzib edited a comment on pull request #13798:
URL: https://github.com/apache/beam/pull/13798#issuecomment-767777390


   > LGTM! I think my same concern is if someone accidently cleans up a docker image, or if someone has locally tested a new version of $LANG that is tagged at a specific release RC, but both seem very unlikely. I would feel more confident if there was a list of images to at least compare against, but that does also involve hardcoding the image names/versions again.
   
   Another solution I considered is using [docker search](https://docs.docker.com/engine/reference/commandline/search/) to list the images that have been uploaded to Docker Hub. Unfortunately the docker search tool does not seem to offer the functionality to do this (it can find repos, but not list tags, for example). We could alternatively curl and parse a json blob from docker hub's API endpoint, but that seems like overkill here.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org