[GitHub] [phoenix-connectors] brfrn169 commented on issue #7: PHOENIX-5552 Hive against Phoenix gets 'Expecting "RPAREN", got "L"' …

[GitBox <gi...@apache.org>]

brfrn169 commented on issue #7: PHOENIX-5552 Hive against Phoenix gets 'Expecting "RPAREN", got "L"' …
URL: https://github.com/apache/phoenix-connectors/pull/7#issuecomment-549654680
 
 
   Thank you for the review. @joshelser @ankitsinghal 
   
   >  It seems from the code below, that we are using FILTER_TEXT_CONF_STR instead of serialized filters expression from FILTER_EXPR_CONF_STR for the Tez engine. I don't know the reason for doing it differently for MR and Tez, is this possible to use Filter expression rather than the string while building where clause for tez engine as well?
   
   It seems like we can do this. And tested it locally, it looks worked at least to address this issue (and passed the existing unit tests). But wondering if this change has some side effects or regressions. I'm also not sure the reason for doing it differently for MR and Tez. If we can use Filter expression in Tez mode, I think it's the best. Do we have a way to verify if this change is invalid or not?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services