You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ashutosh Mestry <am...@hortonworks.com> on 2018/08/29 05:47:20 UTC
Review Request 68554: Rename AtlasCluster to AtlasService
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68554/
-----------------------------------------------------------
Review request for atlas and Madhan Neethiraj.
Bugs: ATLAS-2845
https://issues.apache.org/jira/browse/ATLAS-2845
Repository: atlas
Description
-------
**Approach**
Renamed _AtlasCluster_ to _AtlasService_.
Diffs
-----
addons/models/0010-base_model.json c6d251c79
addons/models/patches/004-base_model_replication_attributes.json 1b49ff7fb
client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java d6d2057c3
common/src/main/java/org/apache/atlas/repository/Constants.java 273358360
intg/src/main/java/org/apache/atlas/model/impexp/AtlasCluster.java 320c0c723
repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java ced00b948
repository/src/main/java/org/apache/atlas/repository/impexp/ClusterService.java 4462f2c14
repository/src/main/java/org/apache/atlas/repository/ogm/AtlasClusterDTO.java a96ca497c
repository/src/main/java/org/apache/atlas/repository/ogm/DTORegistry.java d417ce771
repository/src/test/java/org/apache/atlas/repository/impexp/ClusterServiceTest.java 6f624c3ee
repository/src/test/java/org/apache/atlas/repository/impexp/ReplicationEntityAttributeTest.java 90232b7c1
repository/src/test/resources/json/stocksDB-Entities/replicationAttrs.json 444103684
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 7d231252c
webapp/src/test/java/org/apache/atlas/web/resources/AdminExportImportTestIT.java d15605413
Diff: https://reviews.apache.org/r/68554/diff/1/
Testing
-------
**Unit tests**
Tests run.
Thanks,
Ashutosh Mestry
Re: Review Request 68554: Rename AtlasCluster to AtlasService
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68554/#review208080
-----------------------------------------------------------
Fix it, then Ship it!
Perhaps AtlasServer is a better name for AtlasService. Please review.
common/src/main/java/org/apache/atlas/repository/Constants.java
Line 105 (original), 105 (patched)
<https://reviews.apache.org/r/68554/#comment291836>
ATTR_NAME_REPLICATED_TO_CLUSTER ==> ATTR_NAME_REPLICATED_TO
ATTR_NAME_REPLICATED_FROM_CLUSTER ==> ATTR_NAME_REPLICATED_FROM
- Madhan Neethiraj
On Aug. 29, 2018, 5:47 a.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68554/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2018, 5:47 a.m.)
>
>
> Review request for atlas and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2845
> https://issues.apache.org/jira/browse/ATLAS-2845
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Approach**
>
> Renamed _AtlasCluster_ to _AtlasService_.
>
>
> Diffs
> -----
>
> addons/models/0010-base_model.json c6d251c79
> addons/models/patches/004-base_model_replication_attributes.json 1b49ff7fb
> client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java d6d2057c3
> common/src/main/java/org/apache/atlas/repository/Constants.java 273358360
> intg/src/main/java/org/apache/atlas/model/impexp/AtlasCluster.java 320c0c723
> repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java ced00b948
> repository/src/main/java/org/apache/atlas/repository/impexp/ClusterService.java 4462f2c14
> repository/src/main/java/org/apache/atlas/repository/ogm/AtlasClusterDTO.java a96ca497c
> repository/src/main/java/org/apache/atlas/repository/ogm/DTORegistry.java d417ce771
> repository/src/test/java/org/apache/atlas/repository/impexp/ClusterServiceTest.java 6f624c3ee
> repository/src/test/java/org/apache/atlas/repository/impexp/ReplicationEntityAttributeTest.java 90232b7c1
> repository/src/test/resources/json/stocksDB-Entities/replicationAttrs.json 444103684
> webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 7d231252c
> webapp/src/test/java/org/apache/atlas/web/resources/AdminExportImportTestIT.java d15605413
>
>
> Diff: https://reviews.apache.org/r/68554/diff/1/
>
>
> Testing
> -------
>
> **Unit tests**
> Tests run.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 68554: Rename AtlasCluster to AtlasService
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68554/#review208118
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Aug. 30, 2018, 4:21 a.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68554/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2018, 4:21 a.m.)
>
>
> Review request for atlas and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2845
> https://issues.apache.org/jira/browse/ATLAS-2845
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Approach**
>
> Renamed _AtlasCluster_ to _AtlasService_.
>
>
> Diffs
> -----
>
> addons/models/0010-base_model.json c6d251c79
> addons/models/patches/004-base_model_replication_attributes.json 1b49ff7fb
> client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java d6d2057c3
> common/src/main/java/org/apache/atlas/repository/Constants.java 273358360
> dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 14be79216
> intg/src/main/java/org/apache/atlas/model/impexp/AtlasCluster.java 320c0c723
> intg/src/main/java/org/apache/atlas/model/impexp/ExportImportAuditEntry.java 2c83c4214
> repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java ced00b948
> repository/src/main/java/org/apache/atlas/repository/impexp/ClusterService.java 4462f2c14
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportImportAuditService.java 8bd52e6f6
> repository/src/main/java/org/apache/atlas/repository/ogm/AtlasClusterDTO.java a96ca497c
> repository/src/main/java/org/apache/atlas/repository/ogm/DTORegistry.java d417ce771
> repository/src/main/java/org/apache/atlas/repository/ogm/ExportImportAuditEntryDTO.java 963ca51d3
> repository/src/test/java/org/apache/atlas/repository/impexp/ClusterServiceTest.java 6f624c3ee
> repository/src/test/java/org/apache/atlas/repository/impexp/ExportImportAuditServiceTest.java 13277a35f
> repository/src/test/java/org/apache/atlas/repository/impexp/ReplicationEntityAttributeTest.java 90232b7c1
> repository/src/test/resources/json/stocksDB-Entities/replicationAttrs.json 444103684
> webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 7d231252c
> webapp/src/test/java/org/apache/atlas/web/resources/AdminExportImportTestIT.java d15605413
>
>
> Diff: https://reviews.apache.org/r/68554/diff/4/
>
>
> Testing
> -------
>
> **Unit tests**
> Tests run.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 68554: Rename AtlasCluster to AtlasService
Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68554/
-----------------------------------------------------------
(Updated Aug. 30, 2018, 4:21 a.m.)
Review request for atlas and Madhan Neethiraj.
Changes
-------
Updates include: Addressed review comments.
Bugs: ATLAS-2845
https://issues.apache.org/jira/browse/ATLAS-2845
Repository: atlas
Description
-------
**Approach**
Renamed _AtlasCluster_ to _AtlasService_.
Diffs (updated)
-----
addons/models/0010-base_model.json c6d251c79
addons/models/patches/004-base_model_replication_attributes.json 1b49ff7fb
client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java d6d2057c3
common/src/main/java/org/apache/atlas/repository/Constants.java 273358360
dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 14be79216
intg/src/main/java/org/apache/atlas/model/impexp/AtlasCluster.java 320c0c723
intg/src/main/java/org/apache/atlas/model/impexp/ExportImportAuditEntry.java 2c83c4214
repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java ced00b948
repository/src/main/java/org/apache/atlas/repository/impexp/ClusterService.java 4462f2c14
repository/src/main/java/org/apache/atlas/repository/impexp/ExportImportAuditService.java 8bd52e6f6
repository/src/main/java/org/apache/atlas/repository/ogm/AtlasClusterDTO.java a96ca497c
repository/src/main/java/org/apache/atlas/repository/ogm/DTORegistry.java d417ce771
repository/src/main/java/org/apache/atlas/repository/ogm/ExportImportAuditEntryDTO.java 963ca51d3
repository/src/test/java/org/apache/atlas/repository/impexp/ClusterServiceTest.java 6f624c3ee
repository/src/test/java/org/apache/atlas/repository/impexp/ExportImportAuditServiceTest.java 13277a35f
repository/src/test/java/org/apache/atlas/repository/impexp/ReplicationEntityAttributeTest.java 90232b7c1
repository/src/test/resources/json/stocksDB-Entities/replicationAttrs.json 444103684
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 7d231252c
webapp/src/test/java/org/apache/atlas/web/resources/AdminExportImportTestIT.java d15605413
Diff: https://reviews.apache.org/r/68554/diff/4/
Changes: https://reviews.apache.org/r/68554/diff/3-4/
Testing
-------
**Unit tests**
Tests run.
Thanks,
Ashutosh Mestry
Re: Review Request 68554: Rename AtlasCluster to AtlasService
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68554/#review208100
-----------------------------------------------------------
Fix it, then Ship it!
common/src/main/java/org/apache/atlas/repository/Constants.java
Line 105 (original), 105 (patched)
<https://reviews.apache.org/r/68554/#comment291872>
Remove "_TO_CLUSTER" from line #105 and #106.
- Madhan Neethiraj
On Aug. 29, 2018, 5:51 p.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68554/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2018, 5:51 p.m.)
>
>
> Review request for atlas and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2845
> https://issues.apache.org/jira/browse/ATLAS-2845
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Approach**
>
> Renamed _AtlasCluster_ to _AtlasService_.
>
>
> Diffs
> -----
>
> addons/models/0010-base_model.json c6d251c79
> addons/models/patches/004-base_model_replication_attributes.json 1b49ff7fb
> client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java d6d2057c3
> common/src/main/java/org/apache/atlas/repository/Constants.java 273358360
> dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 14be79216
> intg/src/main/java/org/apache/atlas/model/impexp/AtlasCluster.java 320c0c723
> intg/src/main/java/org/apache/atlas/model/impexp/ExportImportAuditEntry.java 2c83c4214
> repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java ced00b948
> repository/src/main/java/org/apache/atlas/repository/impexp/ClusterService.java 4462f2c14
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportImportAuditService.java 8bd52e6f6
> repository/src/main/java/org/apache/atlas/repository/ogm/AtlasClusterDTO.java a96ca497c
> repository/src/main/java/org/apache/atlas/repository/ogm/DTORegistry.java d417ce771
> repository/src/main/java/org/apache/atlas/repository/ogm/ExportImportAuditEntryDTO.java 963ca51d3
> repository/src/test/java/org/apache/atlas/repository/impexp/ClusterServiceTest.java 6f624c3ee
> repository/src/test/java/org/apache/atlas/repository/impexp/ExportImportAuditServiceTest.java 13277a35f
> repository/src/test/java/org/apache/atlas/repository/impexp/ReplicationEntityAttributeTest.java 90232b7c1
> repository/src/test/resources/json/stocksDB-Entities/replicationAttrs.json 444103684
> webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 7d231252c
> webapp/src/test/java/org/apache/atlas/web/resources/AdminExportImportTestIT.java d15605413
>
>
> Diff: https://reviews.apache.org/r/68554/diff/3/
>
>
> Testing
> -------
>
> **Unit tests**
> Tests run.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 68554: Rename AtlasCluster to AtlasService
Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68554/
-----------------------------------------------------------
(Updated Aug. 29, 2018, 5:51 p.m.)
Review request for atlas and Madhan Neethiraj.
Changes
-------
Updates include:
- Addressed review comments.
Bugs: ATLAS-2845
https://issues.apache.org/jira/browse/ATLAS-2845
Repository: atlas
Description
-------
**Approach**
Renamed _AtlasCluster_ to _AtlasService_.
Diffs (updated)
-----
addons/models/0010-base_model.json c6d251c79
addons/models/patches/004-base_model_replication_attributes.json 1b49ff7fb
client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java d6d2057c3
common/src/main/java/org/apache/atlas/repository/Constants.java 273358360
dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 14be79216
intg/src/main/java/org/apache/atlas/model/impexp/AtlasCluster.java 320c0c723
intg/src/main/java/org/apache/atlas/model/impexp/ExportImportAuditEntry.java 2c83c4214
repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java ced00b948
repository/src/main/java/org/apache/atlas/repository/impexp/ClusterService.java 4462f2c14
repository/src/main/java/org/apache/atlas/repository/impexp/ExportImportAuditService.java 8bd52e6f6
repository/src/main/java/org/apache/atlas/repository/ogm/AtlasClusterDTO.java a96ca497c
repository/src/main/java/org/apache/atlas/repository/ogm/DTORegistry.java d417ce771
repository/src/main/java/org/apache/atlas/repository/ogm/ExportImportAuditEntryDTO.java 963ca51d3
repository/src/test/java/org/apache/atlas/repository/impexp/ClusterServiceTest.java 6f624c3ee
repository/src/test/java/org/apache/atlas/repository/impexp/ExportImportAuditServiceTest.java 13277a35f
repository/src/test/java/org/apache/atlas/repository/impexp/ReplicationEntityAttributeTest.java 90232b7c1
repository/src/test/resources/json/stocksDB-Entities/replicationAttrs.json 444103684
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 7d231252c
webapp/src/test/java/org/apache/atlas/web/resources/AdminExportImportTestIT.java d15605413
Diff: https://reviews.apache.org/r/68554/diff/2/
Changes: https://reviews.apache.org/r/68554/diff/1-2/
Testing
-------
**Unit tests**
Tests run.
Thanks,
Ashutosh Mestry