You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Jörg Schaible <jo...@gmx.de> on 2015/04/14 18:52:48 UTC

Fwd: [2/3] [math] Wrap jgit buildnumber plugin in a profile triggered by .git exsiting.

Good idea! What about moving this profile into parent?

--------------- Weitergeleitete Nachricht (Anfang)

Betreff: [2/3] [math] Wrap jgit buildnumber plugin in a profile triggered by 
.git exsiting.
Absender: luc-1oDqGaOF3Lkdnm+yROfE0A@public.gmane.org
Datum: Tue, 14 Apr 2015 12:02:06 +0000
Newsgruppe: gmane.comp.jakarta.commons.scm

Wrap jgit buildnumber plugin in a profile triggered by .git exsiting.

This should prevent numerous warnings when building from a source
archive instead of from git checkout.

Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/6e24e58f
Tree: http://git-wip-us.apache.org/repos/asf/commons-math/tree/6e24e58f
Diff: http://git-wip-us.apache.org/repos/asf/commons-math/diff/6e24e58f

Branch: refs/heads/release
Commit: 6e24e58ffbe8d65d2953242fa05310c8226e1f69
Parents: e30d37c
Author: Luc Maisonobe <lu...@public.gmane.org>
Authored: Tue Apr 14 13:40:34 2015 +0200
Committer: Luc Maisonobe <lu...@public.gmane.org>
Committed: Tue Apr 14 13:40:34 2015 +0200

----------------------------------------------------------------------
 pom.xml | 42 +++++++++++++++++++++++++++---------------
 1 file changed, 27 insertions(+), 15 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-math/blob/6e24e58f/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 9c100e2..70348af 100644
--- a/pom.xml
+++ b/pom.xml
@@ -527,21 +527,6 @@
           <additionalparam>-header &apos;&lt;script 
type=&quot;text/javascript&quot; 
src=&quot;http://cdn.mathjax.org/mathjax/latest/MathJax.js?config=TeX-AMS-MML_HTMLorMML&quot;&gt;&lt;/script&gt;&apos;</additionalparam>
         </configuration>
       </plugin>
-      <plugin>
-        <groupId>ru.concerteza.buildnumber</groupId>
-        <artifactId>maven-jgit-buildnumber-plugin</artifactId>
-        <version>${math.jgit.buildnumber.version}</version>
-        <executions>
-          <execution>
-            <phase>generate-resources</phase>
-            <goals>
-              <goal>extract-buildnumber</goal>
-            </goals>
-          </execution>
-        </executions>
-        <configuration>
-        </configuration>
-      </plugin>
     </plugins>
   </build>
 
@@ -693,6 +678,33 @@
 
   <profiles>
     <profile>
+      <id>jgit-buildnumber</id>
+      <activation>
+        <file>
+          <exists>.git</exists>
+        </file>
+      </activation>
+      <build>
+        <plugins>
+          <plugin>
+            <groupId>ru.concerteza.buildnumber</groupId>
+            <artifactId>maven-jgit-buildnumber-plugin</artifactId>
+            <version>${math.jgit.buildnumber.version}</version>
+            <executions>
+              <execution>
+                <phase>generate-resources</phase>
+                <goals>
+                  <goal>extract-buildnumber</goal>
+                </goals>
+              </execution>
+            </executions>
+            <configuration>
+            </configuration>
+          </plugin>
+        </plugins>
+      </build>
+    </profile>
+    <profile>
       <id>setup-checkout</id>
       <activation>
         <file>


--------------- Weitergeleitete Nachricht (Ende)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: Fwd: [2/3] [math] Wrap jgit buildnumber plugin in a profile triggered by .git exsiting.

Posted by Luc Maisonobe <lu...@spaceroots.org>.
Le 14/04/2015 18:52, Jörg Schaible a écrit :
> 
> Good idea! What about moving this profile into parent?

I think it would be better if the plugin already used by parent
correctly set up build numbers for git. It is supposed to work, but
I failed using it for 3.4 and delected this plugin as a temporary
alternative. I did not try further, so maybe we should
look more precisely to this.

best regards,
Luc

> 
> --------------- Weitergeleitete Nachricht (Anfang)
> 
> Betreff: [2/3] [math] Wrap jgit buildnumber plugin in a profile triggered by 
> .git exsiting.
> Absender: luc-1oDqGaOF3Lkdnm+yROfE0A@public.gmane.org
> Datum: Tue, 14 Apr 2015 12:02:06 +0000
> Newsgruppe: gmane.comp.jakarta.commons.scm
> 
> Wrap jgit buildnumber plugin in a profile triggered by .git exsiting.
> 
> This should prevent numerous warnings when building from a source
> archive instead of from git checkout.
> 
> Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo
> Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/6e24e58f
> Tree: http://git-wip-us.apache.org/repos/asf/commons-math/tree/6e24e58f
> Diff: http://git-wip-us.apache.org/repos/asf/commons-math/diff/6e24e58f
> 
> Branch: refs/heads/release
> Commit: 6e24e58ffbe8d65d2953242fa05310c8226e1f69
> Parents: e30d37c
> Author: Luc Maisonobe <lu...@public.gmane.org>
> Authored: Tue Apr 14 13:40:34 2015 +0200
> Committer: Luc Maisonobe <lu...@public.gmane.org>
> Committed: Tue Apr 14 13:40:34 2015 +0200
> 
> ----------------------------------------------------------------------
>  pom.xml | 42 +++++++++++++++++++++++++++---------------
>  1 file changed, 27 insertions(+), 15 deletions(-)
> ----------------------------------------------------------------------
> 
> 
> http://git-wip-us.apache.org/repos/asf/commons-math/blob/6e24e58f/pom.xml
> ----------------------------------------------------------------------
> diff --git a/pom.xml b/pom.xml
> index 9c100e2..70348af 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -527,21 +527,6 @@
>            <additionalparam>-header &apos;&lt;script 
> type=&quot;text/javascript&quot; 
> src=&quot;http://cdn.mathjax.org/mathjax/latest/MathJax.js?config=TeX-AMS-MML_HTMLorMML&quot;&gt;&lt;/script&gt;&apos;</additionalparam>
>          </configuration>
>        </plugin>
> -      <plugin>
> -        <groupId>ru.concerteza.buildnumber</groupId>
> -        <artifactId>maven-jgit-buildnumber-plugin</artifactId>
> -        <version>${math.jgit.buildnumber.version}</version>
> -        <executions>
> -          <execution>
> -            <phase>generate-resources</phase>
> -            <goals>
> -              <goal>extract-buildnumber</goal>
> -            </goals>
> -          </execution>
> -        </executions>
> -        <configuration>
> -        </configuration>
> -      </plugin>
>      </plugins>
>    </build>
>  
> @@ -693,6 +678,33 @@
>  
>    <profiles>
>      <profile>
> +      <id>jgit-buildnumber</id>
> +      <activation>
> +        <file>
> +          <exists>.git</exists>
> +        </file>
> +      </activation>
> +      <build>
> +        <plugins>
> +          <plugin>
> +            <groupId>ru.concerteza.buildnumber</groupId>
> +            <artifactId>maven-jgit-buildnumber-plugin</artifactId>
> +            <version>${math.jgit.buildnumber.version}</version>
> +            <executions>
> +              <execution>
> +                <phase>generate-resources</phase>
> +                <goals>
> +                  <goal>extract-buildnumber</goal>
> +                </goals>
> +              </execution>
> +            </executions>
> +            <configuration>
> +            </configuration>
> +          </plugin>
> +        </plugins>
> +      </build>
> +    </profile>
> +    <profile>
>        <id>setup-checkout</id>
>        <activation>
>          <file>
> 
> 
> --------------- Weitergeleitete Nachricht (Ende)
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org