You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Dandandan (via GitHub)" <gi...@apache.org> on 2026/01/24 13:28:25 UTC
[PR] Avoid metadata lookup for `LocalFileSystem::read_ranges` and `chunked_stream` [arrow-rs-object-store]
Dandandan opened a new pull request, #621:
URL: https://github.com/apache/arrow-rs-object-store/pull/621
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please call them out.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Avoid metadata lookup for `LocalFileSystem::read_ranges` and `chunked_stream` [arrow-rs-object-store]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #621:
URL: https://github.com/apache/arrow-rs-object-store/pull/621#issuecomment-3796838154
Am about out of time for now -- will check back later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Avoid metadata lookup for `LocalFileSystem::read_ranges` and `chunked_stream` [arrow-rs-object-store]
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #621:
URL: https://github.com/apache/arrow-rs-object-store/pull/621#issuecomment-3796821400
> 1. There is some non trivial duplication
Agreed
> There is still a call open_file
You mean outside `get_ranges` or...? At least as part of `get_ranges` I don't see anymore a metadata request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Avoid metadata lookup for `LocalFileSystem::read_ranges` and `chunked_stream` [arrow-rs-object-store]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #621:
URL: https://github.com/apache/arrow-rs-object-store/pull/621#issuecomment-3837457332
I have some thoughts about this one -- will see what I can do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Avoid metadata lookup for `LocalFileSystem::read_ranges` and `chunked_stream` [arrow-rs-object-store]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #621:
URL: https://github.com/apache/arrow-rs-object-store/pull/621#issuecomment-3837702396
@Dandandan -- here is a proposal to simplify the error handling (I think it is somewhat tricky with all the corner cases, so refactoring into some functions makes it easier to see what is happening I think, and convince myself it is correct)
- https://github.com/Dandandan/arrow-rs-object-store/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Avoid metadata lookup for `LocalFileSystem::read_ranges` and `chunked_stream` [arrow-rs-object-store]
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #621:
URL: https://github.com/apache/arrow-rs-object-store/pull/621#issuecomment-3795526514
Doing some testing, it seems that avoiding `File::open` does make a difference.
Perhaps DataFusion can implement a LocalStorage that stores / caches the file descriptors for a query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Avoid metadata lookup for `LocalFileSystem::read_ranges` and `chunked_stream` [arrow-rs-object-store]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #621:
URL: https://github.com/apache/arrow-rs-object-store/pull/621#issuecomment-3796837953
> > 1. There is some non trivial duplication
>
> Agreed
As I played around with this I found that the challenge is that the metadata error is ignored sometimes when desired to get a better error message, but sometimes is needed. I haven't got anything yet that is great
>
> > There is still a call open_file
>
> You mean outside `get_ranges` or...? At least as part of `get_ranges` I don't see anymore a metadata request.
Yeah, I meant in get_opts
https://github.com/apache/arrow-rs-object-store/blob/ea71bafd94fe271af74eae07751db632908608cd/src/local.rs#L421-L420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Avoid metadata lookup for `LocalFileSystem::read_ranges` and `chunked_stream` [arrow-rs-object-store]
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan merged PR #621:
URL: https://github.com/apache/arrow-rs-object-store/pull/621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Avoid metadata lookup for `LocalFileSystem::read_ranges` and `chunked_stream` [arrow-rs-object-store]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #621:
URL: https://github.com/apache/arrow-rs-object-store/pull/621#issuecomment-3841533907
I took the liberty of pushing a commit to fix clippy and to simplify the error handling some more: https://github.com/apache/arrow-rs-object-store/pull/621/commits/6ce209487676812d8563e4519a72d07471adf67a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org