You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jun Rao (JIRA)" <ji...@apache.org> on 2009/10/05 06:07:31 UTC

[jira] Created: (CASSANDRA-470) ByteToken equality test should be based on value

ByteToken equality test should be based on value
------------------------------------------------

                 Key: CASSANDRA-470
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-470
             Project: Cassandra
          Issue Type: Bug
    Affects Versions: 0.5
            Reporter: Jun Rao
            Assignee: Jun Rao
            Priority: Minor


ByteToken equality tests should be based on value of the byte array, instead of object ID.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-470) ByteToken equality test should be based on value

Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jun Rao updated CASSANDRA-470:
------------------------------

    Attachment: issue470.patchv1

Attach a patch.

> ByteToken equality test should be based on value
> ------------------------------------------------
>
>                 Key: CASSANDRA-470
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-470
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.5
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>            Priority: Minor
>         Attachments: issue470.patchv1
>
>
> ByteToken equality tests should be based on value of the byte array, instead of object ID.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-470) ByteToken equality test should be based on value

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762160#action_12762160 ] 

Jonathan Ellis commented on CASSANDRA-470:
------------------------------------------

BytesToken overrides equals:

    @Override
    public boolean equals(Object obj)
    {
        if (this == obj)
            return true;
        if (!(obj instanceof BytesToken))
            return false;
        BytesToken other = (BytesToken) obj;
        return Arrays.equals(token, other.token);
    }

Is there some bug keeping this from being invoked?

> ByteToken equality test should be based on value
> ------------------------------------------------
>
>                 Key: CASSANDRA-470
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-470
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.5
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>            Priority: Minor
>         Attachments: issue470.patchv1
>
>
> ByteToken equality tests should be based on value of the byte array, instead of object ID.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.