You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by kishorvpatil <gi...@git.apache.org> on 2015/05/23 01:32:37 UTC
[GitHub] storm pull request: [STORM-833] Logging framework logback -> log4j...
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/562
[STORM-833] Logging framework logback -> log4j 2.x
As part of changes to logging framework:
- Migrate from logback to log4j2
- Use RFC5424 foramt for routing logs to rsyslog
- Get stdout and stderr logged and rolled
- Add username and sensitivity to rsyslog RFC524 message format.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kishorvpatil/incubator-storm log4j-changes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/562.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #562
----
commit dcf3448ade42ad9b8a6e8054fa71bdd33a147e57
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date: 2015-02-11T20:31:27Z
s/form/from/
commit e2fa07634c4b264137fdc7c3d8dba299c77d04c9
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date: 2015-02-11T20:15:01Z
Addressed review comments.
commit 0bea392bf1415a9de394f583289c3b3c80cc673c
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date: 2015-02-05T21:08:27Z
Updated logging to have two files
commit 23a284a97e06eb2aac798dc5daeff5e772cfc5e7
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date: 2015-02-05T20:58:27Z
First go at this
commit 529774273c8b9730bbd3dcdaba3990de401191e7
Author: Kishor Patil <kp...@yahoo-inc.com>
Date: 2015-03-05T18:24:24Z
Migrate from logback to log4j2
commit d44854af2c92cc068a66b26cb21204145ac67e5e
Author: Kishor Patil <kp...@yahoo-inc.com>
Date: 2015-03-05T21:02:18Z
Fix dependencies
commit 75f56f32b47d47acc40165c78bfb9359e09e400c
Author: Kishor Patil <kp...@yahoo-inc.com>
Date: 2015-03-05T22:18:57Z
Fix license indentation
commit 9908374c76e9348bcb8337d9ee148df2129a9f09
Author: Kishor Patil <kp...@yahoo-inc.com>
Date: 2015-03-06T12:44:07Z
Add daemon logs to syslogs, reformat rsyslog messages
commit 40d96de82081b217b76e5fe5dfed88407360fb1b
Author: Kishor Patil <kp...@yahoo-inc.com>
Date: 2015-03-09T21:18:22Z
Print full stacktrace to syslog
commit e9b2e1e0f9a99466b3a9209efad8ce99131ca709
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date: 2015-03-20T19:57:20Z
YSTORM-853: only log stdout and stderr to .out and .err files
commit ede736784b5d98c1fc8a59b5f458d75806cd7a08
Author: Kishor Patil <kp...@yahoo-inc.com>
Date: 2015-04-16T20:46:34Z
Add username and sensitivity to rsyslog appender
commit 1d7ccf0c6f123b9bf23746a0d23c6f393d3f34e9
Author: Kishor Patil <kp...@yahoo-inc.com>
Date: 2015-04-17T19:50:36Z
Rename configuration name
commit 2f19b50957d70229686f7c0ed6117fde5e86264f
Author: Kishor Patil <kp...@yahoo-inc.com>
Date: 2015-04-17T20:02:51Z
Hide zk payload from logs.
commit bb0ad94e8af2d67ed48df859adf6b01b8774ef20
Author: Kishor Patil <kp...@yahoo-inc.com>
Date: 2015-04-17T20:21:47Z
Rename method and formatting
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-833] Logging framework logback -> log4j...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/562#issuecomment-109294599
Sorry about that I completely forgot about that part. I will try to get a pull request up for it today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-833] Logging framework logback -> log4j...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/562#issuecomment-106092029
For a first pass things look good. I am +1, but I wrote some of the code you cherry picked in so my +1 only applies to code I didn't touch :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-833] Logging framework logback -> log4j...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/562#issuecomment-109091657
We can see Travis CI is complaining that log is exceed 4M again.
(Filed issue: https://issues.apache.org/jira/browse/STORM-850)
To prevent it, we used logback-test.xml from storm-core, and it doesn't converted to log4j2-test.xml.
https://github.com/apache/storm/blob/master/storm-core/test/resources/logback-test.xml
And I can find how to use system environment from config file, but I can't find how to set default value.
It is important since we only need to change log level when running with Travis CI.
I agree its limitation is bad, and current approach may not be best.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-833] Logging framework logback -> log4j...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/562#issuecomment-109325670
No problem. Seems like random test failures make us not checking Travis CI's result.
We should address Kafka random test failure so that we are about to be sure we should take an action when Travis CI complains something is wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-833] Logging framework logback -> log4j...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/562
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-833] Logging framework logback -> log4j...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/562#issuecomment-108544758
Seems with this change the worker will also redact the ZooKeeper authentication payload from the conf, so if it is defined, then the secret is not logged. This is a good additional improvement.
I built the code, ran the tests, and checked that logging was happening with the ExclamationTopology.
I am +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---