You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/05 17:47:55 UTC

[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #1838: chore: use data value directly in tests

iamayushdas opened a new pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838


   Please answer these questions before submitting a pull request, **or your PR will get closed**.
   
   **Why submit this pull request?**
   
   - [ ] Bugfix
   - [ ] New feature provided
   - [x] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   improved test cases for create_and_delete_consumer.spec.js
   
   **Related issues**
   
   fix/resolve #1774
   
   **Checklist:**
   
   - [x] Did you explain what problem does this PR solve? Or what new features have been added?
   - [x] Have you added corresponding test cases?
   - [ ] Have you modified the corresponding document?
   - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-832886508


   Deploy preview for *apisix-dashboard* processing.
   
   Building with commit 8de011a7c223f005c08feecc83f779ae80aae7de
   
   https://app.netlify.com/sites/apisix-dashboard/deploys/6092da427e97870008935d73


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-832886508


   Deploy preview for *apisix-dashboard* ready!
   
   Built with commit 8171e3bc9fe92b1448e42b7854347764108b39d3
   
   https://deploy-preview-1838--apisix-dashboard.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#discussion_r627335494



##########
File path: web/cypress/integration/consumer/create-consumer-with-proxy-mirror-form.spec.js
##########
@@ -17,38 +17,52 @@
 /* eslint-disable no-undef */
 
 context('Create and delete consumer with proxy-mirror plugin form', () => {
-  beforeEach(() => {
-    cy.login();
-
-    cy.fixture('selector.json').as('domSelector');
-    cy.fixture('data.json').as('data');
-  });
-
   const selector = {
+    empty:'.ant-empty-normal',
+    username: '#username',
+    description: '#desc',
+    pluginCard: '.ant-card',
+    drawer: '.ant-drawer-content',
+    dropdown: '.rc-virtual-list',
+    disabledSwitcher: '#disable',
+    codeMirror: '.CodeMirror',
+    notification: '.ant-notification-notice-message',
+    notificationCloseIcon: '.ant-notification-close-icon',
     host: "#host",
     alert: "[role=alert]"
   }

Review comment:
       ```suggestion
       notification: '.ant-notification-notice-message',
       notificationCloseIcon: '.ant-notification-close-icon',
       host: '#host',
       alert: '[role=alert]'
      }
   ```
   It is best to use both single and double quotation marks
   

##########
File path: web/cypress/integration/consumer/create-consumer-with-proxy-mirror-form.spec.js
##########
@@ -17,38 +17,52 @@
 /* eslint-disable no-undef */
 
 context('Create and delete consumer with proxy-mirror plugin form', () => {
-  beforeEach(() => {
-    cy.login();
-
-    cy.fixture('selector.json').as('domSelector');
-    cy.fixture('data.json').as('data');
-  });
-
   const selector = {
+    empty:'.ant-empty-normal',
+    username: '#username',
+    description: '#desc',
+    pluginCard: '.ant-card',
+    drawer: '.ant-drawer-content',
+    dropdown: '.rc-virtual-list',
+    disabledSwitcher: '#disable',
+    codeMirror: '.CodeMirror',
+    notification: '.ant-notification-notice-message',
+    notificationCloseIcon: '.ant-notification-close-icon',
     host: "#host",
     alert: "[role=alert]"
   }

Review comment:
       ```suggestion
       notification: '.ant-notification-notice-message',
       notificationCloseIcon: '.ant-notification-close-icon',
       host: '#host',
       alert: '[role=alert]'
     }
   ```
   It is best to use both single and double quotation marks
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-832886508


   Deploy preview for *apisix-dashboard* ready!
   
   Built with commit 8b3bbbdc968ac0734517c7495647e89a7aef5d1b
   
   https://deploy-preview-1838--apisix-dashboard.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#discussion_r627352223



##########
File path: web/cypress/integration/consumer/create-consumer-with-proxy-mirror-form.spec.js
##########
@@ -17,38 +17,52 @@
 /* eslint-disable no-undef */
 
 context('Create and delete consumer with proxy-mirror plugin form', () => {
-  beforeEach(() => {
-    cy.login();
-
-    cy.fixture('selector.json').as('domSelector');
-    cy.fixture('data.json').as('data');
-  });
-
   const selector = {
+    empty:'.ant-empty-normal',
+    username: '#username',
+    description: '#desc',
+    pluginCard: '.ant-card',
+    drawer: '.ant-drawer-content',
+    dropdown: '.rc-virtual-list',
+    disabledSwitcher: '#disable',
+    codeMirror: '.CodeMirror',
+    notification: '.ant-notification-notice-message',
+    notificationCloseIcon: '.ant-notification-close-icon',
     host: "#host",
     alert: "[role=alert]"
   }

Review comment:
       This is my problem. I didn't see the space gap clearly when commenting on my phone……




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#discussion_r627350348



##########
File path: web/cypress/integration/consumer/create-consumer-with-proxy-mirror-form.spec.js
##########
@@ -17,38 +17,52 @@
 /* eslint-disable no-undef */
 
 context('Create and delete consumer with proxy-mirror plugin form', () => {
-  beforeEach(() => {
-    cy.login();
-
-    cy.fixture('selector.json').as('domSelector');
-    cy.fixture('data.json').as('data');
-  });
-
   const selector = {
+    empty:'.ant-empty-normal',
+    username: '#username',
+    description: '#desc',
+    pluginCard: '.ant-card',
+    drawer: '.ant-drawer-content',
+    dropdown: '.rc-virtual-list',
+    disabledSwitcher: '#disable',
+    codeMirror: '.CodeMirror',
+    notification: '.ant-notification-notice-message',
+    notificationCloseIcon: '.ant-notification-close-icon',
     host: "#host",
     alert: "[role=alert]"
   }

Review comment:
       ![image](https://user-images.githubusercontent.com/2106987/117294079-ce10a900-aea4-11eb-86c4-6d730be2ac5d.png)
   
   Why there have spaces?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-832886508


   Deploy preview for *apisix-dashboard* ready!
   
   Built with commit 8de011a7c223f005c08feecc83f779ae80aae7de
   
   https://deploy-preview-1838--apisix-dashboard.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#discussion_r627379075



##########
File path: web/cypress/integration/consumer/create-consumer-with-proxy-mirror-form.spec.js
##########
@@ -17,38 +17,52 @@
 /* eslint-disable no-undef */
 
 context('Create and delete consumer with proxy-mirror plugin form', () => {
-  beforeEach(() => {
-    cy.login();
-
-    cy.fixture('selector.json').as('domSelector');
-    cy.fixture('data.json').as('data');
-  });
-
   const selector = {
+    empty:'.ant-empty-normal',
+    username: '#username',
+    description: '#desc',
+    pluginCard: '.ant-card',
+    drawer: '.ant-drawer-content',
+    dropdown: '.rc-virtual-list',
+    disabledSwitcher: '#disable',
+    codeMirror: '.CodeMirror',
+    notification: '.ant-notification-notice-message',
+    notificationCloseIcon: '.ant-notification-close-icon',
     host: "#host",
     alert: "[role=alert]"
   }

Review comment:
       ok




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-832886508






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-832886508


   Deploy preview for *apisix-dashboard* ready!
   
   Built with commit 23750f6b7c9a3b678005ddf5fe8922824f83f202
   
   https://deploy-preview-1838--apisix-dashboard.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-832886508


   Deploy preview for *apisix-dashboard* processing.
   
   Building with commit 8171e3bc9fe92b1448e42b7854347764108b39d3
   
   https://app.netlify.com/sites/apisix-dashboard/deploys/6093f711b360b800077342b3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-833202301


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1838](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7674b38) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/16dfb4d669b4cb6eecc38a3bee92067938dc5ccb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (16dfb4d) will **increase** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 7674b38 differs from pull request most recent head dc2146e. Consider uploading reports for the commit dc2146e to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1838/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1838      +/-   ##
   ==========================================
   + Coverage   72.07%   72.10%   +0.02%     
   ==========================================
     Files         125      125              
     Lines        2944     2947       +3     
     Branches      710      711       +1     
   ==========================================
   + Hits         2122     2125       +3     
     Misses        822      822              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | frontend-e2e-test | `72.10% <ø> (+0.02%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/pages/Route/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1838/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9DcmVhdGUudHN4) | `90.99% <0.00%> (+0.25%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [16dfb4d...dc2146e](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-832886508


   Deploy preview for *apisix-dashboard* processing.
   
   Building with commit e700e4eeacb60155c99bfd1fa39142d7dc28e6e7
   
   https://app.netlify.com/sites/apisix-dashboard/deploys/60936bbea3880f0007935dc8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-833321523


   > @iamayushdas Hi, please update other test cases in other PRs. One PR with one Testcase.
   
   okay sure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-832886508


   Deploy preview for *apisix-dashboard* processing.
   
   Building with commit 7b0b4eefffa9bed7bf420b83760b213b5b546ba4
   
   https://app.netlify.com/sites/apisix-dashboard/deploys/609373c6e081cf0007439cc2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-833451351


   Ok @guoqqqi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas closed pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
iamayushdas closed pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-832886508


   Deploy preview for *apisix-dashboard* processing.
   
   Building with commit 7674b38516bd3f68787108f7a1344bd8c4e563e6
   
   https://app.netlify.com/sites/apisix-dashboard/deploys/609360b67ccffb00078da904


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-832886508






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-833320396


   @iamayushdas Hi, please update other test cases in other PRs. One PR with one Testcase.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-832886508






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-832886508


   Deploy preview for *apisix-dashboard* ready!
   
   Built with commit dc2146eb72bf08f5f0bfcf9d1f3fc1fd3a42af1e
   
   https://deploy-preview-1838--apisix-dashboard.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-832886882


   @guoqqqi have a look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#discussion_r627335494



##########
File path: web/cypress/integration/consumer/create-consumer-with-proxy-mirror-form.spec.js
##########
@@ -17,38 +17,52 @@
 /* eslint-disable no-undef */
 
 context('Create and delete consumer with proxy-mirror plugin form', () => {
-  beforeEach(() => {
-    cy.login();
-
-    cy.fixture('selector.json').as('domSelector');
-    cy.fixture('data.json').as('data');
-  });
-
   const selector = {
+    empty:'.ant-empty-normal',
+    username: '#username',
+    description: '#desc',
+    pluginCard: '.ant-card',
+    drawer: '.ant-drawer-content',
+    dropdown: '.rc-virtual-list',
+    disabledSwitcher: '#disable',
+    codeMirror: '.CodeMirror',
+    notification: '.ant-notification-notice-message',
+    notificationCloseIcon: '.ant-notification-close-icon',
     host: "#host",
     alert: "[role=alert]"
   }

Review comment:
       ```suggestion
       notification: '.ant-notification-notice-message',
       notificationCloseIcon: '.ant-notification-close-icon',
        host: '#host',
        alert: '[role=alert]'
      }
   ```
   It is best to use both single and double quotation marks
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-833202301


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1838](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (23750f6) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/16dfb4d669b4cb6eecc38a3bee92067938dc5ccb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (16dfb4d) will **increase** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1838/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1838      +/-   ##
   ==========================================
   + Coverage   72.07%   72.10%   +0.02%     
   ==========================================
     Files         125      125              
     Lines        2944     2947       +3     
     Branches      710      711       +1     
   ==========================================
   + Hits         2122     2125       +3     
     Misses        822      822              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | frontend-e2e-test | `72.10% <ø> (+0.02%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/pages/Route/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1838/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9DcmVhdGUudHN4) | `90.99% <0.00%> (+0.25%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [16dfb4d...23750f6](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-832886508


   Deploy preview for *apisix-dashboard* ready!
   
   Built with commit d33f80b0b3dc760cea63decbce87172c8e34b138
   
   https://deploy-preview-1838--apisix-dashboard.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-832886508


   Deploy preview for *apisix-dashboard* processing.
   
   Building with commit 8b3bbbdc968ac0734517c7495647e89a7aef5d1b
   
   https://app.netlify.com/sites/apisix-dashboard/deploys/6093f7cd37ecc4000852c4c7


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-832886508






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-833202301


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1838](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1285028) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/16dfb4d669b4cb6eecc38a3bee92067938dc5ccb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (16dfb4d) will **increase** coverage by `0.09%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 1285028 differs from pull request most recent head 23750f6. Consider uploading reports for the commit 23750f6 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1838/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1838      +/-   ##
   ==========================================
   + Coverage   72.07%   72.17%   +0.09%     
   ==========================================
     Files         125      125              
     Lines        2944     2947       +3     
     Branches      710      711       +1     
   ==========================================
   + Hits         2122     2127       +5     
   + Misses        822      820       -2     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | frontend-e2e-test | `72.17% <ø> (+0.09%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/pages/Route/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1838/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9DcmVhdGUudHN4) | `90.99% <0.00%> (+0.25%)` | :arrow_up: |
   | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1838/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `72.13% <0.00%> (+3.27%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [16dfb4d...23750f6](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1838: chore: use data value directly in tests

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1838:
URL: https://github.com/apache/apisix-dashboard/pull/1838#issuecomment-833202301


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1838](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc2146e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/16dfb4d669b4cb6eecc38a3bee92067938dc5ccb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (16dfb4d) will **increase** coverage by `0.09%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1838/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1838      +/-   ##
   ==========================================
   + Coverage   72.07%   72.17%   +0.09%     
   ==========================================
     Files         125      125              
     Lines        2944     2947       +3     
     Branches      710      711       +1     
   ==========================================
   + Hits         2122     2127       +5     
   + Misses        822      820       -2     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | frontend-e2e-test | `72.17% <ø> (+0.09%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/pages/Route/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1838/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9DcmVhdGUudHN4) | `90.99% <0.00%> (+0.25%)` | :arrow_up: |
   | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1838/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `72.13% <0.00%> (+3.27%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [16dfb4d...dc2146e](https://codecov.io/gh/apache/apisix-dashboard/pull/1838?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org