You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by lt...@apache.org on 2006/01/11 02:08:48 UTC

svn commit: r367861 - in /maven/maven-1/plugins/trunk/dashboard: src/plugin-resources/templates/dashboard.jsl xdocs/changes.xml

Author: ltheussl
Date: Tue Jan 10 17:08:46 2006
New Revision: 367861

URL: http://svn.apache.org/viewcvs?rev=367861&view=rev
Log:
PR: MPDASHBOARD-32
maven.dashboard.report.showempty property not honored.

Modified:
    maven/maven-1/plugins/trunk/dashboard/src/plugin-resources/templates/dashboard.jsl
    maven/maven-1/plugins/trunk/dashboard/xdocs/changes.xml

Modified: maven/maven-1/plugins/trunk/dashboard/src/plugin-resources/templates/dashboard.jsl
URL: http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/dashboard/src/plugin-resources/templates/dashboard.jsl?rev=367861&r1=367860&r2=367861&view=diff
==============================================================================
--- maven/maven-1/plugins/trunk/dashboard/src/plugin-resources/templates/dashboard.jsl (original)
+++ maven/maven-1/plugins/trunk/dashboard/src/plugin-resources/templates/dashboard.jsl Tue Jan 10 17:08:46 2006
@@ -85,7 +85,7 @@
     <j:set var="shallDisplay" value="true"/>
     <j:if test="${context.getVariable('maven.dashboard.report.showempty') == 'false'}">
       <x:set var="notEmptyElems" select="aggregator[not(text() = '-')]"/>
-      <j:if test="${notEmptyElems.isEmpty() == 'true'}">
+      <j:if test="${empty(notEmptyElems)}">
         <j:set var="shallDisplay" value="false"/>
       </j:if>
     </j:if>

Modified: maven/maven-1/plugins/trunk/dashboard/xdocs/changes.xml
URL: http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/dashboard/xdocs/changes.xml?rev=367861&r1=367860&r2=367861&view=diff
==============================================================================
--- maven/maven-1/plugins/trunk/dashboard/xdocs/changes.xml (original)
+++ maven/maven-1/plugins/trunk/dashboard/xdocs/changes.xml Tue Jan 10 17:08:46 2006
@@ -25,6 +25,7 @@
   </properties>
   <body>
     <release version="1.9-SNAPSHOT" date="in svn">
+      <action dev="ltheussl" type="fix" issue="MPDASHBOARD-32" due-to="Wim Deblauwe"><code>maven.dashboard.report.showempty</code> property not honored.</action>
       <action dev="aheritier" type="fix" issue="MPDASHBOARD-34" due-to="Philippe Kernevez">Cobertura aggregator don't support offline mode. From now the Cobertura aggregator works only with MAVEN 1.1.</action>
       <action dev="aheritier" type="update" issue="MPDASHBOARD-33" due-to="carlos@apache.org">Update the default checkstyle report location to make it compatible with Checkstyle plugin 3.0+ (MPCHECKSTYLE-40).</action>
       <action dev="carlos" type="add" issue="MPDASHBOARD-31">Added Cobertura aggregator.</action>

Re: svn commit: r367861 - in /maven/maven-1/plugins/trunk/dashboard: src/plugin-resources/templates/dashboard.jsl xdocs/changes.xml

Posted by Arnaud HERITIER <ah...@gmail.com>.
ok cool.
It was certainly with an older release.
Arnaud.

On 1/11/06, Lukas Theussl <lt...@apache.org> wrote:
>
> I checked with m1.0.2 and m1.1b3-SNAPSHOT. Seems to work fine.
>
> -Lukas
>
>
> Arnaud HERITIER wrote:
> >>[SNIP]
> >>URL: http://svn.apache.org/viewcvs?rev=367861&view=rev
> >>Log:
> >>PR: MPDASHBOARD-32
> >>maven.dashboard.report.showempty property not honored.
> >>
> >>[SNIP]
> >
> >
> >
> > -      <j:if test="${notEmptyElems.isEmpty() == 'true'}">
> > +      <j:if test="${empty(notEmptyElems)}">
> > [SNIP]
> >
> > Lukas, did you test it with maven 1.1 and 1.0 ?
> > I remember that there was a problem with the empty function in an old
> > release of Jelly ?
> >
> > Arnaud
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

Re: svn commit: r367861 - in /maven/maven-1/plugins/trunk/dashboard: src/plugin-resources/templates/dashboard.jsl xdocs/changes.xml

Posted by Lukas Theussl <lt...@apache.org>.
I checked with m1.0.2 and m1.1b3-SNAPSHOT. Seems to work fine.

-Lukas


Arnaud HERITIER wrote:
>>[SNIP]
>>URL: http://svn.apache.org/viewcvs?rev=367861&view=rev
>>Log:
>>PR: MPDASHBOARD-32
>>maven.dashboard.report.showempty property not honored.
>>
>>[SNIP]
> 
> 
> 
> -      <j:if test="${notEmptyElems.isEmpty() == 'true'}">
> +      <j:if test="${empty(notEmptyElems)}">
> [SNIP]
> 
> Lukas, did you test it with maven 1.1 and 1.0 ?
> I remember that there was a problem with the empty function in an old
> release of Jelly ?
> 
> Arnaud
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: svn commit: r367861 - in /maven/maven-1/plugins/trunk/dashboard: src/plugin-resources/templates/dashboard.jsl xdocs/changes.xml

Posted by Arnaud HERITIER <ah...@gmail.com>.
>
> [SNIP]
> URL: http://svn.apache.org/viewcvs?rev=367861&view=rev
> Log:
> PR: MPDASHBOARD-32
> maven.dashboard.report.showempty property not honored.
>
> [SNIP]


-      <j:if test="${notEmptyElems.isEmpty() == 'true'}">
+      <j:if test="${empty(notEmptyElems)}">
[SNIP]

Lukas, did you test it with maven 1.1 and 1.0 ?
I remember that there was a problem with the empty function in an old
release of Jelly ?

Arnaud