You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/25 13:24:36 UTC
[GitHub] [superset] diegomedina248 opened a new pull request #19370: fix(sql lab): replace the output column in the query history table
diegomedina248 opened a new pull request #19370:
URL: https://github.com/apache/superset/pull/19370
### SUMMARY
The current output column in the Query History table in the SQL Lab currently displays the schema if the query failed.
The resulting UI is a column with "View results" button for successful queries and some seemingly random text if the query failed that lacks the appropriate context.
This PR makes some cosmetic changes that include:
* Removing the schema for failed queries and leaving the field blank
* Renaming the column from "output" to "results"
* Renaming the button for successful queries from "View results" to "View"
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
<img width="1289" alt="Screen Shot 2022-03-25 at 09 30 29" src="https://user-images.githubusercontent.com/17252075/160128737-0c957259-b7fe-49df-a61d-42ec335591ac.png">
After:
<img width="1284" alt="Screen Shot 2022-03-25 at 09 48 22" src="https://user-images.githubusercontent.com/17252075/160128766-7acf76f2-2004-433b-b826-4f045fa20722.png">
### TESTING INSTRUCTIONS
1. Open the SQL Lab
2. Execute valid and invalid queries
Ensure the results column show the View button for successful queries & nothing for failed ones.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codemaster08240328 commented on a change in pull request #19370: fix(sql lab): replace the output column in the query history table
Posted by GitBox <gi...@apache.org>.
codemaster08240328 commented on a change in pull request #19370:
URL: https://github.com/apache/superset/pull/19370#discussion_r840779671
##########
File path: superset-frontend/src/SqlLab/components/QueryTable/index.tsx
##########
@@ -35,10 +35,12 @@ import ResultSet from '../ResultSet';
import HighlightedSql from '../HighlightedSql';
import { StaticPosition, verticalAlign, StyledTooltip } from './styles';
-interface QueryTableQuery extends Omit<Query, 'state' | 'sql' | 'progress'> {
+interface QueryTableQuery
+ extends Omit<Query, 'state' | 'sql' | 'progress' | 'output' | 'results'> {
Review comment:
Any reason you need to omit `output` from `Query`?
Let's keep it if we don't have specific reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] diegomedina248 commented on a change in pull request #19370: fix(sql lab): replace the output column in the query history table
Posted by GitBox <gi...@apache.org>.
diegomedina248 commented on a change in pull request #19370:
URL: https://github.com/apache/superset/pull/19370#discussion_r840781538
##########
File path: superset-frontend/src/SqlLab/components/QueryTable/index.tsx
##########
@@ -35,10 +35,12 @@ import ResultSet from '../ResultSet';
import HighlightedSql from '../HighlightedSql';
import { StaticPosition, verticalAlign, StyledTooltip } from './styles';
-interface QueryTableQuery extends Omit<Query, 'state' | 'sql' | 'progress'> {
+interface QueryTableQuery
+ extends Omit<Query, 'state' | 'sql' | 'progress' | 'output' | 'results'> {
Review comment:
because the output is no longer used, so it shouldn't be part of the interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19370: fix(sql lab): replace the output column in the query history table
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #19370:
URL: https://github.com/apache/superset/pull/19370#issuecomment-1079077220
# [Codecov](https://codecov.io/gh/apache/superset/pull/19370?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19370](https://codecov.io/gh/apache/superset/pull/19370?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2556d56) into [master](https://codecov.io/gh/apache/superset/commit/45c28c8046c56d4ebe1dfaf0235783fe864ae75f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (45c28c8) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #19370 +/- ##
=======================================
Coverage 66.67% 66.67%
=======================================
Files 1676 1676
Lines 64714 64712 -2
Branches 6506 6505 -1
=======================================
- Hits 43150 43149 -1
Misses 19878 19878
+ Partials 1686 1685 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.32% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntend/src/SqlLab/components/QueryHistory/index.tsx](https://codecov.io/gh/apache/superset/pull/19370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5SGlzdG9yeS9pbmRleC50c3g=) | `66.66% <ø> (ø)` | |
| [...rontend/src/SqlLab/components/QueryTable/index.tsx](https://codecov.io/gh/apache/superset/pull/19370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUvaW5kZXgudHN4) | `69.09% <100.00%> (+0.66%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19370?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19370?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [45c28c8...2556d56](https://codecov.io/gh/apache/superset/pull/19370?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org