[GitHub] graceguo-supercat opened a new pull request #3711: fix the slice permission issue after user click-edit new slice title

[GitBox <gi...@apache.org>]

graceguo-supercat opened a new pull request #3711: fix the slice permission issue after user click-edit new slice title
URL: https://github.com/apache/incubator-superset/pull/3711
 
 
   step to reproduce:
   
   1. user start visualize a query from sql lab, and landing in explore view. At this time the title of visualized query is default to undefined - untitled
   2. user click the slice title and change slice title.
   3. then user clicks 'Save' button on upper left page, so that Save a Slice modal will show up.
   4. when user save slice by using modal, they will see 'You don't have right to change this slice' message.
   
   
   The root cause here is when user click-edit new query data, we save the query as new slice, but in the responses, should use updated form_data which was generated after slice was created. Otherwise we missed new slice_id in the form_data response data.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services