You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/07 12:59:29 UTC
[GitHub] [arrow] paleolimbot opened a new pull request, #12824: ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes
paleolimbot opened a new pull request, #12824:
URL: https://github.com/apache/arrow/pull/12824
In ARROW-15857 (#12734) we fixed the nightly failures on rhub/fedora-clang-devel by a kludge modifying the default makefile, but also upstreamed the fixes (https://github.com/rstudio/sass/pull/104 and https://github.com/r-hub/rhub-linux-builders/pull/60). These upstreams are now both released, so we can remove the kludge from modification of the docker image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot merged pull request #12824: ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes
Posted by GitBox <gi...@apache.org>.
paleolimbot merged PR #12824:
URL: https://github.com/apache/arrow/pull/12824
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #12824: ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes
Posted by GitBox <gi...@apache.org>.
assignUser commented on PR #12824:
URL: https://github.com/apache/arrow/pull/12824#issuecomment-1220559700
https://github.com/github-actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on pull request #12824: ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on PR #12824:
URL: https://github.com/apache/arrow/pull/12824#issuecomment-1224281113
I investigated this, and the rhub image doesn't need anything additional to ensure that libc++ is getting used even with the `-std=gnu++XXX` flag:
```bash
# docker run --rm -it rhub/fedora-clang-devel bash
printf "#include <ciso646>\n#ifdef _LIBCPP_VERSION\n#error Using libc++\n#endif" > test.cpp
/opt/R-devel/bin/R CMD SHLIB test.cpp
# /usr/bin/clang++ -std=gnu++14 -stdlib=libc++ -I"/opt/R-devel/lib64/R/include" -DNDEBUG -I/usr/local/include -fpic -g -O2 -c test.cpp -o test.o
# test.cpp:3:2: error: Using libc++
# #error Using libc++
# ^
# 1 error generated.
/usr/bin/clang++ -stdlib=libc++ -I/usr/local/include -g -O2 -std=gnu++11 -E test.cpp | head -n 1
# test.cpp:3:2: error: Using libc++
# #error Using libc++
# ^
# 1 error generated.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12824: ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12824:
URL: https://github.com/apache/arrow/pull/12824#issuecomment-1220561053
Revision: 45b7556d4ba10ed68685b5859d9fac193a3a9864
Submitted crossbow builds: [ursacomputing/crossbow @ actions-7509e9f2b3](https://github.com/ursacomputing/crossbow/branches/all?query=actions-7509e9f2b3)
|Task|Status|
|----|------|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-7509e9f2b3-github-test-r-linux-as-cran)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on pull request #12824: ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on PR #12824:
URL: https://github.com/apache/arrow/pull/12824#issuecomment-1215222961
@github-actions crossbow submit test-r-linux-as-cran
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12824: ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12824:
URL: https://github.com/apache/arrow/pull/12824#issuecomment-1091742938
Revision: fa02aa5369bda7f0ac41b8644743ab9e7ab215d5
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1827](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1827)
|Task|Status|
|----|------|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1827-github-test-r-linux-as-cran)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #12824: ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes
Posted by GitBox <gi...@apache.org>.
assignUser commented on PR #12824:
URL: https://github.com/apache/arrow/pull/12824#issuecomment-1220560278
@github-actions crossbow submit test-r-linux-as-cran
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on pull request #12824: ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on PR #12824:
URL: https://github.com/apache/arrow/pull/12824#issuecomment-1224266456
@github-actions crossbow submit test-r-linux-as-cran
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12824: ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12824:
URL: https://github.com/apache/arrow/pull/12824#issuecomment-1209388284
Revision: d6cfe592639c42bc5d1ce8be843a763beb539079
Submitted crossbow builds: [ursacomputing/crossbow @ actions-32da4d031b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-32da4d031b)
|Task|Status|
|----|------|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-32da4d031b-github-test-r-linux-as-cran)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12824: ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12824:
URL: https://github.com/apache/arrow/pull/12824#issuecomment-1224455685
Revision: 1748b23973ae6a0b4f70443668f5067d2da05b00
Submitted crossbow builds: [ursacomputing/crossbow @ actions-d762bd3886](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d762bd3886)
|Task|Status|
|----|------|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-d762bd3886-github-test-r-linux-as-cran)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #12824: ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes
Posted by GitBox <gi...@apache.org>.
assignUser commented on PR #12824:
URL: https://github.com/apache/arrow/pull/12824#issuecomment-1220626346
@paleolimbot I re-ran the failed job with `arrow_r_dev` but it worked so I started another run which also passed, maybe a change in the docker image or some other flakiness?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on pull request #12824: ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on PR #12824:
URL: https://github.com/apache/arrow/pull/12824#issuecomment-1091706744
@github-actions crossbow submit test-r-linux-as-cran
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on pull request #12824: ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on PR #12824:
URL: https://github.com/apache/arrow/pull/12824#issuecomment-1116142233
As per ARROW-16310, we also need to make sure that test-fedora-r-clang-sanitizer passes since the current Makefile modifications might be affecting the install of tzdb.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12824: ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #12824:
URL: https://github.com/apache/arrow/pull/12824#issuecomment-1225178101
Benchmark runs are scheduled for baseline = 3c13dc4e54b0c539349610ffd791e5d5cabb40e2 and contender = c90d07f74a2af924bf156391a67914d03a6119c6. c90d07f74a2af924bf156391a67914d03a6119c6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/223d97af7f344950923a03c9889195a2...1bb924b921054ef7abff08814eb8dcfa/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/81d8bb0165604c01a5a9c28cc466454f...8b597d0372114a09bab8b8bfe9d4afe7/)
[Failed :arrow_down:0.82% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/6be0409f557644fd9917873a0b2b8658...b8825b9ffcf34f34b2bbeeb52adb31a8/)
[Failed :arrow_down:2.78% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/3078763b8f494f338abade626a382c50...6afcd81736f04f89a459e961235f2981/)
Buildkite builds:
[Finished] [`c90d07f7` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1358)
[Failed] [`c90d07f7` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1374)
[Failed] [`c90d07f7` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1356)
[Failed] [`c90d07f7` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1373)
[Finished] [`3c13dc4e` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1357)
[Failed] [`3c13dc4e` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1373)
[Failed] [`3c13dc4e` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1355)
[Failed] [`3c13dc4e` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1372)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on pull request #12824: ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on PR #12824:
URL: https://github.com/apache/arrow/pull/12824#issuecomment-1095304776
(This is failing because the latest release of the 'sass' package didn't actually contain the upstreamed fix despite the NEWS bullet indicating that it was, so we have to wait for 0.4.2 to be released: https://github.com/rstudio/sass/releases).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on pull request #12824: ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on PR #12824:
URL: https://github.com/apache/arrow/pull/12824#issuecomment-1220668018
I can't personally explain the previous failure (the code chunk I added back in seems pretty well fenced to the one image). Thanks for taking a look! I need to open up the image locally to make sure that gnu extensions are not being loaded with those Makevars (I can't see why they would be with those flags but seeing as the image has *one* job...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12824: ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12824:
URL: https://github.com/apache/arrow/pull/12824#issuecomment-1215336316
Revision: 45b7556d4ba10ed68685b5859d9fac193a3a9864
Submitted crossbow builds: [ursacomputing/crossbow @ actions-c9fd68f714](https://github.com/ursacomputing/crossbow/branches/all?query=actions-c9fd68f714)
|Task|Status|
|----|------|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-c9fd68f714-github-test-r-linux-as-cran)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12824: ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12824:
URL: https://github.com/apache/arrow/pull/12824#issuecomment-1215081100
Revision: 3c439dedf3a01bdbdf71843695296e5401658465
Submitted crossbow builds: [ursacomputing/crossbow @ actions-c95ef40d0f](https://github.com/ursacomputing/crossbow/branches/all?query=actions-c95ef40d0f)
|Task|Status|
|----|------|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-c95ef40d0f-github-test-r-linux-as-cran)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on pull request #12824: ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on PR #12824:
URL: https://github.com/apache/arrow/pull/12824#issuecomment-1209364318
@github-actions crossbow submit test-r-linux-as-cran
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on pull request #12824: ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on PR #12824:
URL: https://github.com/apache/arrow/pull/12824#issuecomment-1209491412
This looks like it works...I was waiting on a release of the 'sass' package that didn't properly pick up linker flags from the `CXXFLAGS` environment variable after I'd upstreamed the fix to rhub and the sass package. I don't spend a lot of time in the CI so it should probably have a look from @assignUser before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #12824: ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #12824:
URL: https://github.com/apache/arrow/pull/12824#issuecomment-1209136458
@paleolimbot What's the status on this? Should this PR be kept open?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on pull request #12824: ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on PR #12824:
URL: https://github.com/apache/arrow/pull/12824#issuecomment-1215032709
@github-actions crossbow submit test-r-linux-as-cran
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org