You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/07 22:04:36 UTC
[GitHub] [arrow] kyle-mccarthy opened a new pull request #7371: ARROW-8736: [Rust] [DataFusion] Table API should provide a schema() method
kyle-mccarthy opened a new pull request #7371:
URL: https://github.com/apache/arrow/pull/7371
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kyle-mccarthy commented on a change in pull request #7371: ARROW-8736: [Rust] [DataFusion] Table API should provide a schema() method
Posted by GitBox <gi...@apache.org>.
kyle-mccarthy commented on a change in pull request #7371:
URL: https://github.com/apache/arrow/pull/7371#discussion_r437013853
##########
File path: rust/datafusion/src/execution/table_impl.rs
##########
@@ -131,6 +132,11 @@ impl Table for TableImpl {
) -> Result<Vec<RecordBatch>> {
ctx.collect_plan(&self.plan.clone(), batch_size)
}
+
+ /// Returns the schema from the logical plan
+ fn schema(&self) -> &Box<Schema> {
Review comment:
So I was able to get the ref of the boxed value using `as_ref` -- let me know if that is what you were intending.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove closed pull request #7371: ARROW-8736: [Rust] [DataFusion] Table API should provide a schema() method
Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #7371:
URL: https://github.com/apache/arrow/pull/7371
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on a change in pull request #7371: ARROW-8736: [Rust] [DataFusion] Table API should provide a schema() method
Posted by GitBox <gi...@apache.org>.
andygrove commented on a change in pull request #7371:
URL: https://github.com/apache/arrow/pull/7371#discussion_r436435692
##########
File path: rust/datafusion/src/execution/table_impl.rs
##########
@@ -131,6 +132,11 @@ impl Table for TableImpl {
) -> Result<Vec<RecordBatch>> {
ctx.collect_plan(&self.plan.clone(), batch_size)
}
+
+ /// Returns the schema from the logical plan
+ fn schema(&self) -> &Box<Schema> {
Review comment:
I'm curious, would it be possible to just return `&Schema` here? I know we tend to return `Arc<Schema>` in many places and this is a pattern I introduced when I was less familiar with Rust, but it would be good to start moving away from this pattern where we can.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7371: ARROW-8736: [Rust] [DataFusion] Table API should provide a schema() method
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7371:
URL: https://github.com/apache/arrow/pull/7371#issuecomment-640288022
https://issues.apache.org/jira/browse/ARROW-8736
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org