You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/06/05 18:05:51 UTC

[GitHub] [incubator-apisix] Miss-you opened a new pull request #1661: [doc]Supplement the 'X-API-KEY' parameter for each interface that operates admin.

Miss-you opened a new pull request #1661:
URL: https://github.com/apache/incubator-apisix/pull/1661


   Supplement the 'X-API-KEY' parameter for each interface that operates admin.
   
   NOTE: Please read the Contributing.md guidelines before submitting your patch:
   
   https://github.com/apache/incubator-apisix/blob/master/Contributing.md#how-to-add-a-new-feature-or-change-an-existing-one
   
   ### Summary
   
   SUMMARY_HERE
   
   ### Full changelog
   
   * [Implement ...]
   * [Add related tests]
   * ...
   
   ### Issues resolved
   
   Fix #XXX
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1661: [doc]Supplement the 'X-API-KEY' parameter for each interface that operates admin.

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1661:
URL: https://github.com/apache/incubator-apisix/pull/1661#discussion_r436225677



##########
File path: doc/admin-api-cn.md
##########
@@ -19,11 +19,13 @@
 
 # 目录
 
-* [Route](#route)
-* [Service](#service)
-* [Consumer](#consumer)
-* [Upstream](#upstream)
-* [SSL](#ssl)
+- [目录](#%e7%9b%ae%e5%bd%95)

Review comment:
       we'd better use Chinese here. `#%e7%9b%ae%e5%bd%95` is not a good choice.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis merged pull request #1661: [doc]Supplement the 'X-API-KEY' parameter for each interface that operates admin.

Posted by GitBox <gi...@apache.org>.
membphis merged pull request #1661:
URL: https://github.com/apache/incubator-apisix/pull/1661


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] Miss-you commented on a change in pull request #1661: [doc]Supplement the 'X-API-KEY' parameter for each interface that operates admin.

Posted by GitBox <gi...@apache.org>.
Miss-you commented on a change in pull request #1661:
URL: https://github.com/apache/incubator-apisix/pull/1661#discussion_r436228014



##########
File path: doc/admin-api-cn.md
##########
@@ -19,11 +19,13 @@
 
 # 目录
 
-* [Route](#route)
-* [Service](#service)
-* [Consumer](#consumer)
-* [Upstream](#upstream)
-* [SSL](#ssl)
+- [目录](#%e7%9b%ae%e5%bd%95)

Review comment:
       Hi, after submitting last night I noticed that due to the vs code markdown plugin, it automatically generates a list of headings that overwrite the past ones, I need to fix that part!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on pull request #1661: [doc]Supplement the 'X-API-KEY' parameter for each interface that operates admin.

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1661:
URL: https://github.com/apache/incubator-apisix/pull/1661#issuecomment-640329687


   @Miss-you many thx


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] Miss-you commented on pull request #1661: [doc]Supplement the 'X-API-KEY' parameter for each interface that operates admin.

Posted by GitBox <gi...@apache.org>.
Miss-you commented on pull request #1661:
URL: https://github.com/apache/incubator-apisix/pull/1661#issuecomment-639956260


   Hi, after submitting last night I noticed that due to the vs code markdown plugin, it automatically generates a list of headings that overwrite the past ones, I need to fix that part!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org