[GitHub] [buildstream] gtristan commented on issue #613: BuildStream should exit early if an unknown alias is used within a URL

[GitBox <gi...@apache.org>]

gtristan commented on issue #613:
URL: https://github.com/apache/buildstream/issues/613#issuecomment-1046148419


   This is now implemented, we now raise an error when an invalid alias is used, and this should happen at preflight time before building anything.
   
   Current code in `Source.mark_download_url()` says:
   
   ```python
           # If there is an alias in use, ensure that it exists in the project
           if alias:
               project = self._get_project()
               if not project.alias_exists(alias, first_pass=self.__first_pass):
                   raise SourceError(
                       "{}: Invalid alias '{}' specified in URL: {}".format(self, alias, url),
                       reason="invalid-source-alias",
                   )
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org