You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/28 08:44:01 UTC
[GitHub] [airflow] turbaszek opened a new issue #13945: Add conf not importable from airflow rule
turbaszek opened a new issue #13945:
URL: https://github.com/apache/airflow/issues/13945
**Description**
A new rule should be added to Airflow upgrade check to verify that users import `conf` from proper place and their code will work with 2.0.
**Use case / motivation**
In 1.10 users can do:
```py
In [1]: from airflow import conf
In [2]: conf
Out[2]: <airflow.configuration.AirflowConfigParser at 0x7f6f28650f28>
```
in 2.0 it's not possible:
```py
In [1]: from airflow import conf
---------------------------------------------------------------------------
ImportError Traceback (most recent call last)
<ipython-input-1-2cf28b1802b4> in <module>
----> 1 from airflow import conf
ImportError: cannot import name 'conf'
```
**Are you willing to submit a PR?**
Possibly if time allows 🕐
**Related Issues**
N/A
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] griffincosgrove commented on issue #13945: Add conf not importable from airflow rule
Posted by GitBox <gi...@apache.org>.
griffincosgrove commented on issue #13945:
URL: https://github.com/apache/airflow/issues/13945#issuecomment-769067946
Hey @turbaszek, I am interested in making a PR for this.
I see you tagged this with good first issue. I am still a novice when it comes to airflow, so if you could help me with the review I think we can accomplish this together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on issue #13945: Add conf not importable from airflow rule
Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #13945:
URL: https://github.com/apache/airflow/issues/13945#issuecomment-779719382
@digitalsimboja you can work on as @griffincosgrove seems to be inactive for last few days
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] griffincosgrove commented on issue #13945: Add conf not importable from airflow rule
Posted by GitBox <gi...@apache.org>.
griffincosgrove commented on issue #13945:
URL: https://github.com/apache/airflow/issues/13945#issuecomment-770235683
hey @turbaszek, struggling to get started with this PR. Could you elaborate more on "Airflow upgrade check", not sure about the implementation strategy at the moment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] digitalsimboja commented on issue #13945: Add conf not importable from airflow rule
Posted by GitBox <gi...@apache.org>.
digitalsimboja commented on issue #13945:
URL: https://github.com/apache/airflow/issues/13945#issuecomment-799571381
Yes,
That is correct.
Regards
On Mon, Mar 15, 2021, 4:42 PM eladkal ***@***.***> wrote:
> @turbaszek <https://github.com/turbaszek> @digitalsimboja
> <https://github.com/digitalsimboja> this is solved by #14400
> <https://github.com/apache/airflow/pull/14400> correct?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/airflow/issues/13945#issuecomment-799522219>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AHUTWR3HCUE25YWREWVMOJDTDYTF5ANCNFSM4WWUCMUQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] digitalsimboja commented on issue #13945: Add conf not importable from airflow rule
Posted by GitBox <gi...@apache.org>.
digitalsimboja commented on issue #13945:
URL: https://github.com/apache/airflow/issues/13945#issuecomment-779775250
@turbaszek Thanks I am taking it on already. Do I need to install anything in order to access the file. I have looking through the repo I have but yet to locate the file at **apache/airflow/tree/v1-10-stable/airflow/upgrade**. Need to mention that I run Airflow on WSL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] digitalsimboja commented on issue #13945: Add conf not importable from airflow rule
Posted by GitBox <gi...@apache.org>.
digitalsimboja commented on issue #13945:
URL: https://github.com/apache/airflow/issues/13945#issuecomment-779674749
Hi @turbaszek is @griffincosgrove working on this issue already, if not I will like to take it up. I am new to Airflow as well and looking for a good-first-issue to taken on. Could this be assigned to me if @griffincosgrove is occupied at the moment. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on issue #13945: Add conf not importable from airflow rule
Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #13945:
URL: https://github.com/apache/airflow/issues/13945#issuecomment-770365545
> Could you elaborate more on "Airflow upgrade check", not sure about the implementation strategy at the moment?
@griffincosgrove upgrade check is additional package that can be installed next to Airflow 1.10.X and allows users check if they are ready to upgrade to Airflow 2.0:
https://github.com/apache/airflow/tree/v1-10-stable/airflow/upgrade
As you can see solving this issue requires to open a PR to `v1-10-stable` branch not `master`. What we need is a new rule that will check that users do not use `from airflow import conf`. Here are existing rules for reference:
https://github.com/apache/airflow/tree/v1-10-stable/airflow/upgrade/rules
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #13945: Add conf not importable from airflow rule
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #13945:
URL: https://github.com/apache/airflow/issues/13945#issuecomment-799522219
@turbaszek @digitalsimboja this is solved by https://github.com/apache/airflow/pull/14400 correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on issue #13945: Add conf not importable from airflow rule
Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #13945:
URL: https://github.com/apache/airflow/issues/13945#issuecomment-779835894
@digitalsimboja you need to checkout to `v1-10-stable` branch, then you should have the `upgrade` directory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal closed issue #13945: Add conf not importable from airflow rule
Posted by GitBox <gi...@apache.org>.
eladkal closed issue #13945:
URL: https://github.com/apache/airflow/issues/13945
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] digitalsimboja edited a comment on issue #13945: Add conf not importable from airflow rule
Posted by GitBox <gi...@apache.org>.
digitalsimboja edited a comment on issue #13945:
URL: https://github.com/apache/airflow/issues/13945#issuecomment-779674749
Hi @turbaszek is @griffincosgrove working on this issue already, if not I will like to take it up. I am new to Airflow as well and looking for a good-first-issue to taken on. Could this be assigned to me if @griffincosgrove is occupied at the moment? Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] griffincosgrove commented on issue #13945: Add conf not importable from airflow rule
Posted by GitBox <gi...@apache.org>.
griffincosgrove commented on issue #13945:
URL: https://github.com/apache/airflow/issues/13945#issuecomment-779764398
Had trouble with this one. Good luck @digitalsimboja!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org