[GitHub] [tinkerpop] spmallette commented on pull request #1714: TINKERPOP-2751: Throw exception if transaction attempted on non transaction supported Graph

[GitBox <gi...@apache.org>]

spmallette commented on PR #1714:
URL: https://github.com/apache/tinkerpop/pull/1714#issuecomment-1158849792

   The obvious downside here is that a non-transactional graph like TinkerGraph will have already recorded changes by this point so if your expectation was a "transaction" you didn't get that. On the other hand, this is how it would work in embedded mode as well. TinkerGraph wouldn't complain until you tried to `commit()`:
   
   ```text
   gremlin> g = TinkerGraph.open().traversal()
   ==>graphtraversalsource[tinkergraph[vertices:0 edges:0], standard]
   gremlin> g.addV()
   ==>v[0]
   gremlin> g.addV()
   ==>v[1]
   gremlin> g.tx().commit()
   Graph does not support transactions
   Type ':help' or ':h' for help.
   Display stack trace? [yN]n
   gremlin> g.V().count()
   ==>2
   ```
   
   So in that sense remote behaves just like embedded so at least the behavior is consistent. 
   
   VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org