You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2017/08/28 14:11:11 UTC
Review Request 61944: Backend should sort repo_version by version
string
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61944/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
Bugs: AMBARI-21828
https://issues.apache.org/jira/browse/AMBARI-21828
Repository: ambari
Description
-------
Provide the FE with the correctly sorted list of repo_versions
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 7a53e91bb0
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 282f159a66
Diff: https://reviews.apache.org/r/61944/diff/1/
Testing
-------
Manual. Automated pending.
Thanks,
Nate Cole
Re: Review Request 61944: Backend should sort repo_version by version
string
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61944/#review183947
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Aug. 28, 2017, 5:11 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61944/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2017, 5:11 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-21828
> https://issues.apache.org/jira/browse/AMBARI-21828
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Provide the FE with the correctly sorted list of repo_versions
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 7a53e91bb0
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 282f159a66
>
>
> Diff: https://reviews.apache.org/r/61944/diff/1/
>
>
> Testing
> -------
>
> Manual. Automated:
>
> [WARNING] Tests run: 4841, Failures: 0, Errors: 0, Skipped: 35
> [INFO]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:02.208s
> [INFO] Finished at: Mon Aug 28 10:35:36 EDT 2017
> [INFO] Final Memory: 99M/1912M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 61944: Backend should sort repo_version by version
string
Posted by Nate Cole <nc...@hortonworks.com>.
> On Aug. 28, 2017, 5:14 p.m., Jonathan Hurley wrote:
> > I didn't crack open compare_versions, but I assume that VersionUtils can handle string-to-int? For example 1.10.1.1 comes after 1.9.1.1?
VersionUtils does, but doesn't compare build numbers. compareVersions (local) defers to VersionUtils and then build numbers since we can use those for testing.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61944/#review183987
-----------------------------------------------------------
On Aug. 28, 2017, 10:11 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61944/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2017, 10:11 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-21828
> https://issues.apache.org/jira/browse/AMBARI-21828
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Provide the FE with the correctly sorted list of repo_versions
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 7a53e91bb0
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 282f159a66
>
>
> Diff: https://reviews.apache.org/r/61944/diff/1/
>
>
> Testing
> -------
>
> Manual. Automated:
>
> [WARNING] Tests run: 4841, Failures: 0, Errors: 0, Skipped: 35
> [INFO]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:02.208s
> [INFO] Finished at: Mon Aug 28 10:35:36 EDT 2017
> [INFO] Final Memory: 99M/1912M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 61944: Backend should sort repo_version by version
string
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61944/#review183987
-----------------------------------------------------------
Ship it!
I didn't crack open compare_versions, but I assume that VersionUtils can handle string-to-int? For example 1.10.1.1 comes after 1.9.1.1?
- Jonathan Hurley
On Aug. 28, 2017, 10:11 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61944/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2017, 10:11 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-21828
> https://issues.apache.org/jira/browse/AMBARI-21828
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Provide the FE with the correctly sorted list of repo_versions
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 7a53e91bb0
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 282f159a66
>
>
> Diff: https://reviews.apache.org/r/61944/diff/1/
>
>
> Testing
> -------
>
> Manual. Automated:
>
> [WARNING] Tests run: 4841, Failures: 0, Errors: 0, Skipped: 35
> [INFO]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:02.208s
> [INFO] Finished at: Mon Aug 28 10:35:36 EDT 2017
> [INFO] Final Memory: 99M/1912M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>