You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "jujoramos (GitHub)" <gi...@apache.org> on 2018/11/09 10:17:24 UTC

[GitHub] [geode] jujoramos opened pull request #2822: GEODE-5667: Fix manual-start default value

GEODE-5667: Fix manual-start default value

- Fixed minor warnings in test classes.
- The `create gateway-receiver` command now sets the `manual-start`
property as `true` when the parameter is specified without a value.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [X] Is your initial contribution a single, squashed commit?

- [X] Does `gradlew build` run cleanly?

- [X] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jujoramos closed pull request #2822: GEODE-5667: Fix manual-start default value

Posted by "jujoramos (GitHub)" <gi...@apache.org>.
[ pull request closed by jujoramos ]

[ Full content available at: https://github.com/apache/geode/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jujoramos commented on issue #2822: GEODE-5667: Fix manual-start default value

Posted by "jujoramos (GitHub)" <gi...@apache.org>.
@davebarnes97: I'm trying to check why the `integrationTest` CI build is failing but, unfortunately, the [link](https://concourse.apachegeode-ci.info/builds/14585) provided by GitHub doesn't work (it shows a never ending loading page) so I'll need to run this locally to check what's happening.
Will add a new squashed commit once I find the problem.
Cheers.

[ Full content available at: https://github.com/apache/geode/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] davebarnes97 commented on issue #2822: GEODE-5667: Fix manual-start default value

Posted by "davebarnes97 (GitHub)" <gi...@apache.org>.
@jujoramos When you merge this PR, please keep the JIRA ticket open and reassign it to me. I'll update the user guide.

[ Full content available at: https://github.com/apache/geode/pull/2822 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org