You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/28 19:33:06 UTC
[GitHub] [spark] jchen5 opened a new pull request, #38432: [SPARK-36124][SQL][WIP] Support subqueries with correlation through set operators
jchen5 opened a new pull request, #38432:
URL: https://github.com/apache/spark/pull/38432
## What changes were proposed in this pull request?
Adds support for subquery decorrelation with UNION, INTERSECT, and EXCEPT on the correlation paths. For example:
```
SELECT t1a, (
SELECT sum(b) FROM (
SELECT t2b as b FROM t2 WHERE t2a = t1.t1a
INTERSECT
SELECT t3b as b FROM t3 WHERE t3a = t1.t1a
))
FROM t1
```
### Why are the changes needed?
To improve subquery support in Spark.
### Does this PR introduce _any_ user-facing change?
Before this change, queries like this would return an error like: `Decorrelate inner query through Union is not supported.`
After this PR, this query can run successfully.
### How was this patch tested?
Unit tests and SQL query tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jchen5 commented on pull request #38432: [SPARK-36124][SQL][WIP] Support subqueries with correlation through set operators
Posted by GitBox <gi...@apache.org>.
jchen5 commented on PR #38432:
URL: https://github.com/apache/spark/pull/38432#issuecomment-1295378945
@allisonwang-db @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jchen5 commented on pull request #38432: [SPARK-36124][SQL][WIP] Support subqueries with correlation through set operators
Posted by GitBox <gi...@apache.org>.
jchen5 commented on PR #38432:
URL: https://github.com/apache/spark/pull/38432#issuecomment-1297289148
This rewrite still needs some work, I found that it is not introducing DomainJoins properly, working on a fix for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jchen5 commented on pull request #38432: [SPARK-36124][SQL][WIP] Support subqueries with correlation through set operators
Posted by GitBox <gi...@apache.org>.
jchen5 commented on PR #38432:
URL: https://github.com/apache/spark/pull/38432#issuecomment-1372381214
Created a new PR here: https://github.com/apache/spark/pull/39375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jchen5 closed pull request #38432: [SPARK-36124][SQL][WIP] Support subqueries with correlation through set operators
Posted by GitBox <gi...@apache.org>.
jchen5 closed pull request #38432: [SPARK-36124][SQL][WIP] Support subqueries with correlation through set operators
URL: https://github.com/apache/spark/pull/38432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #38432: [SPARK-36124][SQL][WIP] Support subqueries with correlation through set operators
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #38432:
URL: https://github.com/apache/spark/pull/38432#issuecomment-1296050692
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org