You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/17 05:22:59 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #37546: [SPARK-40116][R][INFRA] Pin Arrow version to 8.0.0 in AppVeyor
HyukjinKwon opened a new pull request, #37546:
URL: https://github.com/apache/spark/pull/37546
### What changes were proposed in this pull request?
This PR proposes to pin the Arrow version to 8.0.0 in AppVeyor for now to recover the build.
### Why are the changes needed?
SparkR does not support Arrow 9.0.0 ([SPARK-40114](https://issues.apache.org/jira/browse/SPARK-40114)) so the tests fail:
- With Arrow 9.0.0 (https://ci.appveyor.com/project/HyukjinKwon/spark/builds/44490387)
- With Arrow 8.0.0 (https://ci.appveyor.com/project/HyukjinKwon/spark/builds/44159034)
Should recover the tests first because it looks it's going to take a while to add the Arrow 9.0.0 support.
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
CI in this PR should test it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #37546: [SPARK-40116][R][INFRA] Remove Arrow in AppVeyor for now
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #37546:
URL: https://github.com/apache/spark/pull/37546#issuecomment-1217541108
Should we revert [SPARK-39913](https://issues.apache.org/jira/browse/SPARK-39913)？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #37546: [SPARK-40116][R][INFRA] Remove Arrow in AppVeyor for now
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #37546:
URL: https://github.com/apache/spark/pull/37546#issuecomment-1217532724
BTW, it must be due to that I missed that GitHub Action SparkR tests used pre-built old SparkR image on SPARK-39913.
- https://github.com/LuciferYang/spark/runs/7664917131?check_suite_focus=true
```
sparkSQL_arrow:
SparkSQL Arrow optimization: .................
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37546: [SPARK-40116][R][INFRA] Pin Arrow version to 8.0.0 in AppVeyor
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37546:
URL: https://github.com/apache/spark/pull/37546#issuecomment-1217518683
Let me remove it for now (so it can skip the test)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37546: [SPARK-40116][R][INFRA] Pin Arrow version to 8.0.0 in AppVeyor
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37546:
URL: https://github.com/apache/spark/pull/37546#issuecomment-1217518525
Okay, seems like manual installation doesn't work due to the compliation (since R package only maintains binaries for latest versions).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37546: [SPARK-40116][R][INFRA] Pin Arrow version to 8.0.0 in AppVeyor
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37546:
URL: https://github.com/apache/spark/pull/37546#issuecomment-1217520901
Merged to master.
Missing Arrow is already tested in the previous commit.
I will take a look for Arrow 9.0.0 soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #37546: [SPARK-40116][R][INFRA] Pin Arrow version to 8.0.0 in AppVeyor
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #37546:
URL: https://github.com/apache/spark/pull/37546#discussion_r947501063
##########
appveyor.yml:
##########
@@ -42,7 +42,10 @@ install:
# Install SBT and dependencies
- ps: .\dev\appveyor-install-dependencies.ps1
# Required package for R unit tests. xml2 is required to use jUnit reporter in testthat.
- - cmd: Rscript -e "install.packages(c('knitr', 'rmarkdown', 'testthat', 'e1071', 'survival', 'arrow', 'xml2'), repos='https://cloud.r-project.org/')"
+ - cmd: Rscript -e "install.packages(c('knitr', 'rmarkdown', 'testthat', 'e1071', 'survival', 'xml2'), repos='https://cloud.r-project.org/')"
+ # TODO(SPARK-40114): support Arrow 9.0.0
+ - cmd: Rscript -e "install.packages(c('devtools'), repos='https://cloud.r-project.org/')"
+ - cmd: Rscript -e "devtools::install_version('arrow', version='8.0.0', repos='https://cloud.r-project.org')"
Review Comment:
```suggestion
# TODO(SPARK-40114): Add 'arrow' back with supporting Arrow 9.0.0
- cmd: Rscript -e "install.packages(c('knitr', 'rmarkdown', 'testthat', 'e1071', 'survival', 'xml2'), repos='https://cloud.r-project.org/')"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #37546: [SPARK-40116][R][INFRA] Pin Arrow version to 8.0.0 in AppVeyor
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #37546: [SPARK-40116][R][INFRA] Pin Arrow version to 8.0.0 in AppVeyor
URL: https://github.com/apache/spark/pull/37546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37546: [SPARK-40116][R][INFRA] Remove Arrow in AppVeyor for now
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37546:
URL: https://github.com/apache/spark/pull/37546#issuecomment-1217658952
Jvm arrow 9.0.0 is fine. It's a problem in R library of Arrow. I'll make a fix hopefully soon anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #37546: [SPARK-40116][R][INFRA] Remove Arrow in AppVeyor for now
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #37546:
URL: https://github.com/apache/spark/pull/37546#issuecomment-1217537951
> BTW, it must be due to that I missed that GitHub Action SparkR tests used pre-built old SparkR image on [SPARK-39913](https://issues.apache.org/jira/browse/SPARK-39913).
>
> * https://github.com/LuciferYang/spark/runs/7664917131?check_suite_focus=true
>
> ```
> sparkSQL_arrow:
> SparkSQL Arrow optimization: .................
> ```
Is this why GA can test successfully?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org