You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by "altman08 (via GitHub)" <gi...@apache.org> on 2026/07/17 11:41:29 UTC

[PR] bthread: convert ADD/SUB_TLS_PTHREAD_LOCK_COUNT macros to inline function (brpc)

altman08 opened a new pull request, #3394:
URL: https://github.com/apache/brpc/pull/3394

   …tions
   
   Replace the function-like macros ADD_TLS_PTHREAD_LOCK_COUNT and SUB_TLS_PTHREAD_LOCK_COUNT with inline functions
   AddTlsPthreadLockCount() and SubTlsPthreadLockCount() (with matching no-op definitions in the BRPC_DEBUG_BTHREAD_SCHE_SAFETY=0 branch). Macros lack type safety and scoping, so encapsulating the logic in regular functions is clearer and safer while keeping the same behavior. All call sites are updated accordingly.
   
   ### What problem does this PR solve?
   
   Issue Number: resolve 
   
   Problem Summary:
   
   ### What is changed and the side effects?
   
   Changed:
   
   Side effects:
   - Performance effects:
   
   - Breaking backward compatibility: 
   
   ---
   ### Check List:
   - Please make sure your changes are compilable.
   - When providing us with a new feature, it is best to add related tests.
   - Please follow [Contributor Covenant Code of Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org


Re: [PR] bthread: convert ADD/SUB_TLS_PTHREAD_LOCK_COUNT macros to inline function (brpc)

Posted by "yanglimingcn (via GitHub)" <gi...@apache.org>.
yanglimingcn commented on PR #3394:
URL: https://github.com/apache/brpc/pull/3394#issuecomment-5009984126

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org


Re: [PR] bthread: convert ADD/SUB_TLS_PTHREAD_LOCK_COUNT macros to inline function (brpc)

Posted by "yanglimingcn (via GitHub)" <gi...@apache.org>.
yanglimingcn merged PR #3394:
URL: https://github.com/apache/brpc/pull/3394


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org