You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2018/03/05 14:47:53 UTC

[GitHub] flink pull request #5640: [FLINK-8839] [sql-client] Fix table source factory...

GitHub user twalthr opened a pull request:

    https://github.com/apache/flink/pull/5640

    [FLINK-8839] [sql-client] Fix table source factory discovery

    ## What is the purpose of the change
    
    This PR fixes the table source factory discovery by adding dependencies to the classloader. It also implements an `ExecutionContext` that can be reused during the same session.
    
    
    ## Brief change log
    
    - New `ExecutionContext` abstraction
    - Possibility to pass a classloader to the Java service provider
    
    
    ## Verifying this change
    
    - See `DependencyTest`
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? JavaDocs


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-8839

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5640.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5640
    
----
commit 8c7b1427f94082dc023073125b32eceda556d8cd
Author: Timo Walther <tw...@...>
Date:   2018-03-05T12:46:41Z

    [FLINK-8839] [sql-client] Fix table source factory discovery

----


---

[GitHub] flink pull request #5640: [FLINK-8839] [sql-client] Fix table source factory...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5640


---

[GitHub] flink issue #5640: [FLINK-8839] [sql-client] Fix table source factory discov...

Posted by twalthr <gi...@git.apache.org>.

Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/5640
  
    Merging...


---