[GitHub] [activemq] gemmellr commented on a change in pull request #647: [AMQ-7442] Support JDK11 full build and code style

[GitBox <gi...@apache.org>]

gemmellr commented on a change in pull request #647:
URL: https://github.com/apache/activemq/pull/647#discussion_r638735781



##########
File path: activemq-http/src/test/java/org/apache/activemq/transport/https/HttpsClientSettingsHostnameVerificationDisabledTest.java
##########
@@ -93,7 +93,13 @@ protected ActiveMQConnectionFactory createConnectionFactory()
 
         return factory;
     }
-    
-
 
+    @Override
+    public void runBare() throws Throwable {
+        try {
+            super.runBare();
+        } catch (Exception e) {
+            e.printStackTrace();

Review comment:
       I think the point being made was that doing that means this TLS config related test is now pretty much useless, if it wont fail even while it is throwing, and you might as well have ignored it or deleted it for all the good it will now do most of the time.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org