You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/08 06:20:23 UTC

[GitHub] [flink] wuchong commented on pull request #11985: [FLINK-16989][table] Support ScanTableSource in blink planner

wuchong commented on pull request #11985:
URL: https://github.com/apache/flink/pull/11985#issuecomment-625654598


   Hi @danny0405 , thanks for reviewing. I have addressed the comments. Some major changes:
   
   1. I updated `TimeAttributeITCase` to use the new factories as sources which covers watermark and computed column.
   2. Keep the implementation of the original `CatalogSourceTable` and rename to `LegacyCatalogSourceTable`.
   3. Rename test classes `DynamicTableSourceITCase` to `ScanTableSourceITCase`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org