You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/07 09:12:58 UTC

[GitHub] [flink] twalthr commented on a change in pull request #11036: [hotfix][example] Add StreamWindowSQLExample.jar to dist

twalthr commented on a change in pull request #11036: [hotfix][example] Add StreamWindowSQLExample.jar to dist
URL: https://github.com/apache/flink/pull/11036#discussion_r376283746
 
 

 ##########
 File path: flink-examples/flink-examples-table/src/main/java/org/apache/flink/table/examples/java/StreamWindowSQLExample.java
 ##########
 @@ -60,7 +62,6 @@ public static void main(String[] args) throws Exception {
 		tempFile.deleteOnExit();
 
 Review comment:
   nit: could we move those 4 helper lines into a method like "String path = createTempFile(orders)". They are actually not important for understanding Flink and should not me moved down.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services