[jira] [Commented] (FLINK-9081) ResourceManagerTaskExecutorTest is unstable

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417710#comment-16417710 ] 

ASF GitHub Bot commented on FLINK-9081:
---------------------------------------

GitHub user sihuazhou opened a pull request:

    https://github.com/apache/flink/pull/5783

    [FLINK-9081][test] Harden ResourceManagerTaskExecutorTest

    ## What is the purpose of the change
    
    Currently, `heartbeatTimeout` is 5, it's too small, so the `ResourceManagerTaskExecutorTest.testRegisterTaskExecutor()` could be unstable on travis easily, this PR set `heartbeatTimeout` to 1000 (the same as the other unit tests that use the `HeartbeatServices`).
    
    ## Brief change log
    
    - set `heartbeat Timeout` to 1000 in `ResourceManagerTaskExecutorTest` and `ResourceManagerJobMasterTest`
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: ( no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sihuazhou/flink FLINK_9081

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5783.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5783
    
----
commit 8f0c6add624ce826cdeaadea8e7501c798a576f2
Author: sihuazhou <su...@...>
Date:   2018-03-28T16:35:24Z

    set heartbeatTimeout=1000 in ResourceManagerJobMasterTest and ResourceManagerTaskExecutorTest.

----


> ResourceManagerTaskExecutorTest is unstable
> -------------------------------------------
>
>                 Key: FLINK-9081
>                 URL: https://issues.apache.org/jira/browse/FLINK-9081
>             Project: Flink
>          Issue Type: Test
>          Components: ResourceManager
>            Reporter: Timo Walther
>            Assignee: Sihua Zhou
>            Priority: Blocker
>             Fix For: 1.5.0
>
>
> It seems that the {{ResourceManagerTaskExecutorTest}} is unstable on Travis using the current master.
> See: https://travis-ci.org/twalthr/flink/jobs/358372805
> {code}
> Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.427 sec <<< FAILURE! - in org.apache.flink.runtime.resourcemanager.ResourceManagerTaskExecutorTest
> testRegisterTaskExecutor(org.apache.flink.runtime.resourcemanager.ResourceManagerTaskExecutorTest)  Time elapsed: 2.778 sec  <<< ERROR!
> java.util.concurrent.ExecutionException: org.apache.flink.runtime.resourcemanager.exceptions.UnknownTaskExecutorException: No TaskExecutor registered under dcb8539dbe8e7211e8fa61cd8e0e0850.
> 	at java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357)
> 	at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1895)
> 	at org.apache.flink.runtime.resourcemanager.ResourceManagerTaskExecutorTest.testRegisterTaskExecutor(ResourceManagerTaskExecutorTest.java:126)
> Caused by: org.apache.flink.runtime.resourcemanager.exceptions.UnknownTaskExecutorException: No TaskExecutor registered under dcb8539dbe8e7211e8fa61cd8e0e0850.
> 	at org.apache.flink.runtime.resourcemanager.ResourceManager.requestTaskManagerInfo(ResourceManager.java:540)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at org.apache.flink.runtime.rpc.akka.AkkaRpcActor.handleRpcInvocation(AkkaRpcActor.java:210)
> 	at org.apache.flink.runtime.rpc.akka.AkkaRpcActor.handleMessage(AkkaRpcActor.java:154)
> 	at org.apache.flink.runtime.rpc.akka.FencedAkkaRpcActor.handleMessage(FencedAkkaRpcActor.java:66)
> 	at org.apache.flink.runtime.rpc.akka.AkkaRpcActor.lambda$onReceive$1(AkkaRpcActor.java:132)
> 	at akka.actor.ActorCell$$anonfun$become$1.applyOrElse(ActorCell.scala:544)
> 	at akka.actor.Actor$class.aroundReceive(Actor.scala:502)
> 	at akka.actor.UntypedActor.aroundReceive(UntypedActor.scala:95)
> 	at akka.actor.ActorCell.receiveMessage(ActorCell.scala:526)
> 	at akka.actor.ActorCell.invoke(ActorCell.scala:495)
> 	at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:257)
> 	at akka.dispatch.Mailbox.run(Mailbox.scala:224)
> 	at akka.dispatch.Mailbox.exec(Mailbox.scala:234)
> 	at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)
> 	at scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)
> 	at scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
> 	at scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)