You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2017/01/26 09:07:33 UTC
Review Request 55979: Wizard modals are closed before confirmation
popup appears
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55979/
-----------------------------------------------------------
Review request for Ambari and Denys Buzhor.
Bugs: ambari-19722
https://issues.apache.org/jira/browse/ambari-19722
Repository: ambari
Description
-------
* Open Kerberos Wizard
* Proceed to step2
* Press "Esc"
* Wizard modal is closed
* Confirmation popup appears
*ER* Confirmation popup should appears before closing wizard modal
This happens because Bootstrap Modal has its own Esc-press handler. It should be disabled
Diffs
-----
ambari-web/app/views/common/modal_popup.js 47b7d61
Diff: https://reviews.apache.org/r/55979/diff/
Testing
-------
20476 tests complete (32 seconds)
153 tests pending
Thanks,
Oleg Nechiporenko
Re: Review Request 55979: Wizard modals are closed before
confirmation popup appears
Posted by Denys Buzhor <bd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55979/#review163108
-----------------------------------------------------------
Ship it!
Ship It!
- Denys Buzhor
On Jan. 26, 2017, 9:07 a.m., Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55979/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2017, 9:07 a.m.)
>
>
> Review request for Ambari and Denys Buzhor.
>
>
> Bugs: ambari-19722
> https://issues.apache.org/jira/browse/ambari-19722
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Open Kerberos Wizard
> * Proceed to step2
> * Press "Esc"
> * Wizard modal is closed
> * Confirmation popup appears
>
> *ER* Confirmation popup should appears before closing wizard modal
>
> This happens because Bootstrap Modal has its own Esc-press handler. It should be disabled
>
>
> Diffs
> -----
>
> ambari-web/app/views/common/modal_popup.js 47b7d61
>
> Diff: https://reviews.apache.org/r/55979/diff/
>
>
> Testing
> -------
>
> 20476 tests complete (32 seconds)
> 153 tests pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>