You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Pooja Nilangekar (Code Review)" <ge...@cloudera.org> on 2019/02/13 23:41:43 UTC

[Impala-ASF-CR] IMPALA-8189: Disable flaky scanner test on S3

Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12478


Change subject: IMPALA-8189: Disable flaky scanner test on S3
......................................................................

IMPALA-8189: Disable flaky scanner test on S3

TestParquet::test_resolution_by_name in test_scanners.py is flaky
due to eventual consistency semantics of S3. It makes sense to
disable this test temporarily since it is not S3 related. In the
long run, the eventual consistency issue would have to be fixed
either by using S3Guard or by modifying the S3Client.

Change-Id: I0771db7c72952f8889a1979c94b02b5f16e4e0ab
---
M tests/query_test/test_scanners.py
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/12478/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0771db7c72952f8889a1979c94b02b5f16e4e0ab
Gerrit-Change-Number: 12478
Gerrit-PatchSet: 1
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>

[Impala-ASF-CR] IMPALA-8189: Disable flaky scanner test on S3

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12478 )

Change subject: IMPALA-8189: Disable flaky scanner test on S3
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0771db7c72952f8889a1979c94b02b5f16e4e0ab
Gerrit-Change-Number: 12478
Gerrit-PatchSet: 1
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Feb 2019 23:56:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8189: Disable flaky scanner test on S3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12478 )

Change subject: IMPALA-8189: Disable flaky scanner test on S3
......................................................................

IMPALA-8189: Disable flaky scanner test on S3

TestParquet::test_resolution_by_name in test_scanners.py is flaky
due to eventual consistency semantics of S3. It makes sense to
disable this test temporarily since it is not S3 related. In the
long run, the eventual consistency issue would have to be fixed
either by using S3Guard or by modifying the S3Client.

Change-Id: I0771db7c72952f8889a1979c94b02b5f16e4e0ab
Reviewed-on: http://gerrit.cloudera.org:8080/12478
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_scanners.py
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/12478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0771db7c72952f8889a1979c94b02b5f16e4e0ab
Gerrit-Change-Number: 12478
Gerrit-PatchSet: 3
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>

[Impala-ASF-CR] IMPALA-8189: Disable flaky scanner test on S3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12478 )

Change subject: IMPALA-8189: Disable flaky scanner test on S3
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0771db7c72952f8889a1979c94b02b5f16e4e0ab
Gerrit-Change-Number: 12478
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Feb 2019 21:33:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8189: Disable flaky scanner test on S3

Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12478 )

Change subject: IMPALA-8189: Disable flaky scanner test on S3
......................................................................


Patch Set 1: Code-Review+1

LGTM


-- 
To view, visit http://gerrit.cloudera.org:8080/12478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0771db7c72952f8889a1979c94b02b5f16e4e0ab
Gerrit-Change-Number: 12478
Gerrit-PatchSet: 1
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Feb 2019 23:55:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8189: Disable flaky scanner test on S3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12478 )

Change subject: IMPALA-8189: Disable flaky scanner test on S3
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2116/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0771db7c72952f8889a1979c94b02b5f16e4e0ab
Gerrit-Change-Number: 12478
Gerrit-PatchSet: 1
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Feb 2019 00:04:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8189: Disable flaky scanner test on S3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12478 )

Change subject: IMPALA-8189: Disable flaky scanner test on S3
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/12478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0771db7c72952f8889a1979c94b02b5f16e4e0ab
Gerrit-Change-Number: 12478
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Feb 2019 01:54:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8189: Disable flaky scanner test on S3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12478 )

Change subject: IMPALA-8189: Disable flaky scanner test on S3
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3776/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/12478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0771db7c72952f8889a1979c94b02b5f16e4e0ab
Gerrit-Change-Number: 12478
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Feb 2019 21:33:34 +0000
Gerrit-HasComments: No