You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Alastair Maw (JIRA)" <ji...@apache.org> on 2007/06/07 19:17:26 UTC

[jira] Closed: (WICKET-606) AbstractTextComponent#setConvertEmptyInputStringToNull(true) does not work with IObjectClassAwareModels (affects TextField, etc.)

     [ https://issues.apache.org/jira/browse/WICKET-606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alastair Maw closed WICKET-606.
-------------------------------

    Resolution: Fixed

This bug is fixed - behaviour is back to 1.2.x-style and trunk prior to the patch that created this particular issue.

If you think trimming whitespace is a bug then please open a separate issue for it.

> AbstractTextComponent#setConvertEmptyInputStringToNull(true) does not work with IObjectClassAwareModels (affects TextField, etc.)
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-606
>                 URL: https://issues.apache.org/jira/browse/WICKET-606
>             Project: Wicket
>          Issue Type: Bug
>    Affects Versions: trunk
>            Reporter: Alastair Maw
>            Assignee: Alastair Maw
>            Priority: Blocker
>             Fix For: 1.3.0-beta2
>
>
> The unit tests ought to cover this, but apparently don't. A TextField should convert empty strings to nulls if you call setConvertEmptyInputStringToNull(true) on it (which the constructors do by default).
> However, this doesn't currently work:
>  - AbstractTextComponent#getConvertEmptyInputStringToNull() is only called from AbstractTextComponent#convertValue(String[]).
>  - AbstractTextComponent#convertValue(String[]) is called from FormComponent#convert(), but only if the component doesn't have a type assigned to it.
>  - As soon as you use a PropertyModel (which implements IObjectClassAwareModel), this means empty strings are no longer converted to nulls.
> This is obviously a great big blocker and needs fixing ASAP.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.