[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #6710: Add a trailer section to data table and measure data table serialization cost on server

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on pull request #6710:
URL: https://github.com/apache/incubator-pinot/pull/6710#issuecomment-806244858


   Since we are adding a new data table version, please use this opportunity to address the TODOs within the `DataTableBuilder`.
   For the `TrailerKeys` enum, let's put an id for each key instead of using the ordinal of the enum. This way it is much easier to manage as long as we don't reuse the ids. Also suggest renaming it to `MetadataKeys`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org