[jira] [Work logged] (BEAM-3811) Add a CancellableQueue to make close methods safer

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-3811?focusedWorklogId=672769&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-672769 ]

ASF GitHub Bot logged work on BEAM-3811:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Nov/21 17:29
            Start Date: 01/Nov/21 17:29
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on pull request #15849:
URL: https://github.com/apache/beam/pull/15849#issuecomment-956433965


   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 672769)
    Time Spent: 0.5h  (was: 20m)

> Add a CancellableQueue to make close methods safer
> --------------------------------------------------
>
>                 Key: BEAM-3811
>                 URL: https://issues.apache.org/jira/browse/BEAM-3811
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Thomas Groh
>            Priority: P3
>              Labels: portability
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> There are multiple locations in which, on a call to {{close}} within some portability service, we wish to close all of our outstanding clients. However, the call to {{close}} can be interleaved with calls to the method which creates a new client. Without having an explicit thread-safe signal from the collection of pending clients, there's no way to ensure that all of the clients for a service are closed when that service is closed. 
>  
> As a result, some clients are only terminated by the forceful termination of the server, killing the connection.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)