You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/08/17 11:26:10 UTC
[GitHub] [servicecomb-java-chassis] david6969xin opened a new pull request #2512: [SCB-1715] Fix idleTimeout not work in client side without keepaliveTimeout set
david6969xin opened a new pull request #2512:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2512
…imeout set
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #2512: [SCB-1715] Fix idleTimeout not work in client side without keepaliveTimeout set
Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #2512:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #2512: [SCB-1715] Fix idleTimeout not work in client side without keepaliveTimeout set
Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #2512:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2512: [SCB-1715] Fix idleTimeout not work in client side without keepaliveTimeout set
Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2512:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2512#discussion_r690333573
##########
File path: transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestTransportClient.java
##########
@@ -73,31 +73,23 @@ public void init(Vertx vertx) throws Exception {
VertxUtils.blockDeploy(vertx, ClientVerticle.class, deployOptionshttp2);
}
- private static HttpClientOptions createHttpClientOptions() {
+ private static HttpClientOptions createHttpClientOptions(boolean http2) {
HttpClientOptions httpClientOptions = new HttpClientOptions();
- httpClientOptions.setMaxPoolSize(TransportClientConfig.getConnectionMaxPoolSize())
- .setIdleTimeout(TransportClientConfig.getConnectionIdleTimeoutInSeconds())
+ httpClientOptions.setIdleTimeout(TransportClientConfig.getConnectionIdleTimeoutInSeconds())
Review comment:
setIdleTimeout should use different configuration for http and http2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] david6969xin commented on a change in pull request #2512: [SCB-1715] Fix idleTimeout not work in client side without keepaliveTimeout set
Posted by GitBox <gi...@apache.org>.
david6969xin commented on a change in pull request #2512:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2512#discussion_r690367741
##########
File path: transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestTransportClient.java
##########
@@ -73,31 +73,23 @@ public void init(Vertx vertx) throws Exception {
VertxUtils.blockDeploy(vertx, ClientVerticle.class, deployOptionshttp2);
}
- private static HttpClientOptions createHttpClientOptions() {
+ private static HttpClientOptions createHttpClientOptions(boolean http2) {
HttpClientOptions httpClientOptions = new HttpClientOptions();
- httpClientOptions.setMaxPoolSize(TransportClientConfig.getConnectionMaxPoolSize())
- .setIdleTimeout(TransportClientConfig.getConnectionIdleTimeoutInSeconds())
+ httpClientOptions.setIdleTimeout(TransportClientConfig.getConnectionIdleTimeoutInSeconds())
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org