You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Hervé BOUTEMY <he...@free.fr> on 2013/11/23 11:46:42 UTC
Re: git commit: Adding envar MAVEN_CMD_LINE_ARGS to shell scripts to provide consistency for accessing CLI args via env.MAVEN_CMD_LINE_ARGS user property (from plugins, for example).
I don't understand the change
there is no Jira issue associated
and it breaks ITs both on Apache's Jenkins instance and on my local machine
can you explain and check, please?
Regards,
Hervé
Le lundi 21 octobre 2013 18:30:19 jdcasey@apache.org a écrit :
> Updated Branches:
> refs/heads/master b0acd5e73 -> 70218af1c
>
>
> Adding envar MAVEN_CMD_LINE_ARGS to shell scripts to provide consistency for
> accessing CLI args via env.MAVEN_CMD_LINE_ARGS user property (from plugins,
> for example).
>
>
> Project: http://git-wip-us.apache.org/repos/asf/maven/repo
> Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/70218af1
> Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/70218af1
> Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/70218af1
>
> Branch: refs/heads/master
> Commit: 70218af1c1824caa892e7e507463ea713faa7133
> Parents: b0acd5e
> Author: John Casey <jd...@commonjava.org>
> Authored: Mon Oct 21 13:26:56 2013 -0500
> Committer: John Casey <jd...@commonjava.org>
> Committed: Mon Oct 21 13:26:56 2013 -0500
>
> ----------------------------------------------------------------------
> apache-maven/src/bin/mvn | 4 ++++
> apache-maven/src/bin/mvnDebug | 4 ++++
> 2 files changed, 8 insertions(+)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/maven/blob/70218af1/apache-maven/src/
> bin/mvn
> ---------------------------------------------------------------------- diff
> --git a/apache-maven/src/bin/mvn b/apache-maven/src/bin/mvn
> index f535d38..1a65193 100755
> --- a/apache-maven/src/bin/mvn
> +++ b/apache-maven/src/bin/mvn
> @@ -182,6 +182,10 @@ if $cygwin; then
> CLASSPATH=`cygpath --path --windows "$CLASSPATH"`
> fi
>
> +# Provide a "standardized" way to retrieve the CLI args that will
> +# work with both Windows and non-Windows executions.
> +export MAVEN_CMD_LINE_ARGS="$@"
> +
> exec "$JAVACMD" \
> $MAVEN_OPTS \
> -classpath "${M2_HOME}"/boot/plexus-classworlds-*.jar \
>
> http://git-wip-us.apache.org/repos/asf/maven/blob/70218af1/apache-maven/src/
> bin/mvnDebug
> ---------------------------------------------------------------------- diff
> --git a/apache-maven/src/bin/mvnDebug b/apache-maven/src/bin/mvnDebug index
> 43a09cc..263a061 100755
> --- a/apache-maven/src/bin/mvnDebug
> +++ b/apache-maven/src/bin/mvnDebug
> @@ -186,6 +186,10 @@ if $cygwin; then
> CLASSPATH=`cygpath --path --windows "$CLASSPATH"`
> fi
>
> +# Provide a "standardized" way to retrieve the CLI args that will
> +# work with both Windows and non-Windows executions.
> +export MAVEN_CMD_LINE_ARGS="$@"
> +
> exec "$JAVACMD" \
> $MAVEN_OPTS \
> $MAVEN_DEBUG_OPTS \
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: git commit: Adding envar MAVEN_CMD_LINE_ARGS to shell scripts to provide consistency for accessing CLI args via env.MAVEN_CMD_LINE_ARGS user property (from plugins, for example).
Posted by Bernd Eckenfels <ec...@zusammenkunft.net>.
I think
X=v
export X
Instead of
export X=v
is more portable. But in any cases, if this is supposed to be an official API it needs to be better tracked and documented (and I somewhat think those "features" make maven POMs less portable).
> Am 23.11.2013 um 17:47 schrieb Igor Fedorenko <ig...@ifedorenko.com>:
>
> I think the change assumes that /bin/sh is bash-compatible. On OSX 10.9
> I have to change mvn script to explicitly require #!/bin/bash, otherwise
> maven invocation fails.
>
> --
> Regards,
> Igor
>
>> On 11/23/2013, 5:46, Hervé BOUTEMY wrote:
>> I don't understand the change
>> there is no Jira issue associated
>>
>> and it breaks ITs both on Apache's Jenkins instance and on my local machine
>>
>> can you explain and check, please?
>>
>> Regards,
>>
>> Hervé
>>
>> Le lundi 21 octobre 2013 18:30:19 jdcasey@apache.org a écrit :
>>> Updated Branches:
>>> refs/heads/master b0acd5e73 -> 70218af1c
>>>
>>>
>>> Adding envar MAVEN_CMD_LINE_ARGS to shell scripts to provide consistency for
>>> accessing CLI args via env.MAVEN_CMD_LINE_ARGS user property (from plugins,
>>> for example).
>>>
>>>
>>> Project: http://git-wip-us.apache.org/repos/asf/maven/repo
>>> Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/70218af1
>>> Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/70218af1
>>> Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/70218af1
>>>
>>> Branch: refs/heads/master
>>> Commit: 70218af1c1824caa892e7e507463ea713faa7133
>>> Parents: b0acd5e
>>> Author: John Casey <jd...@commonjava.org>
>>> Authored: Mon Oct 21 13:26:56 2013 -0500
>>> Committer: John Casey <jd...@commonjava.org>
>>> Committed: Mon Oct 21 13:26:56 2013 -0500
>>>
>>> ----------------------------------------------------------------------
>>> apache-maven/src/bin/mvn | 4 ++++
>>> apache-maven/src/bin/mvnDebug | 4 ++++
>>> 2 files changed, 8 insertions(+)
>>> ----------------------------------------------------------------------
>>>
>>>
>>> http://git-wip-us.apache.org/repos/asf/maven/blob/70218af1/apache-maven/src/
>>> bin/mvn
>>> ---------------------------------------------------------------------- diff
>>> --git a/apache-maven/src/bin/mvn b/apache-maven/src/bin/mvn
>>> index f535d38..1a65193 100755
>>> --- a/apache-maven/src/bin/mvn
>>> +++ b/apache-maven/src/bin/mvn
>>> @@ -182,6 +182,10 @@ if $cygwin; then
>>> CLASSPATH=`cygpath --path --windows "$CLASSPATH"`
>>> fi
>>>
>>> +# Provide a "standardized" way to retrieve the CLI args that will
>>> +# work with both Windows and non-Windows executions.
>>> +export MAVEN_CMD_LINE_ARGS="$@"
>>> +
>>> exec "$JAVACMD" \
>>> $MAVEN_OPTS \
>>> -classpath "${M2_HOME}"/boot/plexus-classworlds-*.jar \
>>>
>>> http://git-wip-us.apache.org/repos/asf/maven/blob/70218af1/apache-maven/src/
>>> bin/mvnDebug
>>> ---------------------------------------------------------------------- diff
>>> --git a/apache-maven/src/bin/mvnDebug b/apache-maven/src/bin/mvnDebug index
>>> 43a09cc..263a061 100755
>>> --- a/apache-maven/src/bin/mvnDebug
>>> +++ b/apache-maven/src/bin/mvnDebug
>>> @@ -186,6 +186,10 @@ if $cygwin; then
>>> CLASSPATH=`cygpath --path --windows "$CLASSPATH"`
>>> fi
>>>
>>> +# Provide a "standardized" way to retrieve the CLI args that will
>>> +# work with both Windows and non-Windows executions.
>>> +export MAVEN_CMD_LINE_ARGS="$@"
>>> +
>>> exec "$JAVACMD" \
>>> $MAVEN_OPTS \
>>> $MAVEN_DEBUG_OPTS \
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: git commit: Adding envar MAVEN_CMD_LINE_ARGS to shell scripts
to provide consistency for accessing CLI args via env.MAVEN_CMD_LINE_ARGS
user property (from plugins, for example).
Posted by Igor Fedorenko <ig...@ifedorenko.com>.
I think the change assumes that /bin/sh is bash-compatible. On OSX 10.9
I have to change mvn script to explicitly require #!/bin/bash, otherwise
maven invocation fails.
--
Regards,
Igor
On 11/23/2013, 5:46, Hervé BOUTEMY wrote:
> I don't understand the change
> there is no Jira issue associated
>
> and it breaks ITs both on Apache's Jenkins instance and on my local machine
>
> can you explain and check, please?
>
> Regards,
>
> Hervé
>
> Le lundi 21 octobre 2013 18:30:19 jdcasey@apache.org a écrit :
>> Updated Branches:
>> refs/heads/master b0acd5e73 -> 70218af1c
>>
>>
>> Adding envar MAVEN_CMD_LINE_ARGS to shell scripts to provide consistency for
>> accessing CLI args via env.MAVEN_CMD_LINE_ARGS user property (from plugins,
>> for example).
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/maven/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/70218af1
>> Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/70218af1
>> Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/70218af1
>>
>> Branch: refs/heads/master
>> Commit: 70218af1c1824caa892e7e507463ea713faa7133
>> Parents: b0acd5e
>> Author: John Casey <jd...@commonjava.org>
>> Authored: Mon Oct 21 13:26:56 2013 -0500
>> Committer: John Casey <jd...@commonjava.org>
>> Committed: Mon Oct 21 13:26:56 2013 -0500
>>
>> ----------------------------------------------------------------------
>> apache-maven/src/bin/mvn | 4 ++++
>> apache-maven/src/bin/mvnDebug | 4 ++++
>> 2 files changed, 8 insertions(+)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/maven/blob/70218af1/apache-maven/src/
>> bin/mvn
>> ---------------------------------------------------------------------- diff
>> --git a/apache-maven/src/bin/mvn b/apache-maven/src/bin/mvn
>> index f535d38..1a65193 100755
>> --- a/apache-maven/src/bin/mvn
>> +++ b/apache-maven/src/bin/mvn
>> @@ -182,6 +182,10 @@ if $cygwin; then
>> CLASSPATH=`cygpath --path --windows "$CLASSPATH"`
>> fi
>>
>> +# Provide a "standardized" way to retrieve the CLI args that will
>> +# work with both Windows and non-Windows executions.
>> +export MAVEN_CMD_LINE_ARGS="$@"
>> +
>> exec "$JAVACMD" \
>> $MAVEN_OPTS \
>> -classpath "${M2_HOME}"/boot/plexus-classworlds-*.jar \
>>
>> http://git-wip-us.apache.org/repos/asf/maven/blob/70218af1/apache-maven/src/
>> bin/mvnDebug
>> ---------------------------------------------------------------------- diff
>> --git a/apache-maven/src/bin/mvnDebug b/apache-maven/src/bin/mvnDebug index
>> 43a09cc..263a061 100755
>> --- a/apache-maven/src/bin/mvnDebug
>> +++ b/apache-maven/src/bin/mvnDebug
>> @@ -186,6 +186,10 @@ if $cygwin; then
>> CLASSPATH=`cygpath --path --windows "$CLASSPATH"`
>> fi
>>
>> +# Provide a "standardized" way to retrieve the CLI args that will
>> +# work with both Windows and non-Windows executions.
>> +export MAVEN_CMD_LINE_ARGS="$@"
>> +
>> exec "$JAVACMD" \
>> $MAVEN_OPTS \
>> $MAVEN_DEBUG_OPTS \
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org