[GitHub] [spark] HyukjinKwon commented on a diff in pull request #41030: [SPARK-43352][K8S][TEST] `setPythonSparkConfProperties` should use conf instead of sparkAppConf

["HyukjinKwon (via GitHub)" <gi...@apache.org>]

HyukjinKwon commented on code in PR #41030:
URL: https://github.com/apache/spark/pull/41030#discussion_r1183520393


##########
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/DepsTestsSuite.scala:
##########
@@ -371,7 +371,7 @@ private[spark] trait DepsTestsSuite { k8sSuite: KubernetesSuite =>
   }
 
   private def setPythonSparkConfProperties(conf: SparkAppConf): Unit = {

Review Comment:
   Shall we remove this function? Seems like it's only used once, and doesn't look helping the readability much.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org