[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #895: HDDS-1636. Tracing id is not propagated via async datanode grpc call

[GitBox <gi...@apache.org>]

xiaoyuyao commented on a change in pull request #895: HDDS-1636. Tracing id is not propagated via async datanode grpc call
URL: https://github.com/apache/hadoop/pull/895#discussion_r289986397
 
 

 ##########
 File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/tracing/TracingUtil.java
 ##########
 @@ -99,7 +103,16 @@ public static Scope importAndCreateScope(String name, String encodedParent) {
     if (encodedParent != null && encodedParent.length() > 0) {
       StringBuilder builder = new StringBuilder();
       builder.append(encodedParent);
-      parentSpan = tracer.extract(StringCodec.FORMAT, builder);
+      try {
+        parentSpan = tracer.extract(StringCodec.FORMAT, builder);
+      } catch (Exception ex) {
+        if (LOG.isDebugEnabled()) {
+          LOG.debug("Can't extract tracing from the message.", ex);
+        } else {
+          LOG.warn(
 
 Review comment:
   Should we just LOG.warn() here only?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org