You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xubo245 <gi...@git.apache.org> on 2018/10/22 04:10:05 UTC
[GitHub] carbondata pull request #2839: [CARBONDATA-3030] Remove no use parameter in ...
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/2839
[CARBONDATA-3030] Remove no use parameter in test case
[CARBONDATA-3030] Remove no use parameter in test case
Remove no use parameter in test case
1. remove persistSchema parameter in SDK test case
2. remove isTransactional parameter in SDK test case
because https://github.com/apache/carbondata/pull/2749 remove the parameter in SDK carbonWriter
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xubo245/carbondata CARBONDATA-3030_removeParameter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2839.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2839
----
----
---
[GitHub] carbondata issue #2839: [CARBONDATA-3030] Remove no use parameter in test ca...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2839
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9171/
---
[GitHub] carbondata issue #2839: [CARBONDATA-3030] Remove no use parameter in test ca...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2839
LGTM, the coverage decrease 0.005% is very small for the whole project
---
[GitHub] carbondata issue #2839: [CARBONDATA-3030] Remove no use parameter in test ca...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2839
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1150/
---
[GitHub] carbondata pull request #2839: [CARBONDATA-3030] Remove no use parameter in ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2839
---
[GitHub] carbondata issue #2839: [CARBONDATA-3030] Remove no use parameter in test ca...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2839
retest this please
---
[GitHub] carbondata issue #2839: [CARBONDATA-3030] Remove no use parameter in test ca...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2839
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9208/
---
[GitHub] carbondata issue #2839: [CARBONDATA-3030] Remove no use parameter in test ca...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2839
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/922/
---
[GitHub] carbondata issue #2839: [CARBONDATA-3030] Remove no use parameter in test ca...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2839
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/944/
---
[GitHub] carbondata issue #2839: [CARBONDATA-3030] Remove no use parameter in test ca...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2839
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1120/
---