You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/08/26 15:59:57 UTC

[GitHub] [iceberg-docs] AlexMercedCoder opened a new pull request, #149: blogs update

AlexMercedCoder opened a new pull request, #149:
URL: https://github.com/apache/iceberg-docs/pull/149

   added two blogs to the blogs page


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg-docs] AlexMercedCoder commented on pull request #149: blogs update (4 blogs from dremio)

Posted by GitBox <gi...@apache.org>.
AlexMercedCoder commented on PR #149:
URL: https://github.com/apache/iceberg-docs/pull/149#issuecomment-1257072291

   > > > Could you please be a bit more specific in the commit message about what this patch holds? E.g. "Add 2 new blogs from Dremio" Other than that LGTM!
   > > 
   > > 
   > > adjusted the name, anything else I need to do, or am I good and it will eventually get merged?
   > 
   > Could you please do the same for the commit msg as well?
   
   wouldn't let me edit the old commit messages since there was newer commits, but I had to add a few more blogs so that commit message reflects and updated the title and pull message.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg-docs] AlexMercedCoder commented on a diff in pull request #149: blogs update (4 blogs from dremio)

Posted by GitBox <gi...@apache.org>.
AlexMercedCoder commented on code in PR #149:
URL: https://github.com/apache/iceberg-docs/pull/149#discussion_r993849870


##########
landing-page/content/common/blogs.md:
##########
@@ -32,6 +50,7 @@ Here is a list of company blogs that talk about Iceberg. The blogs are ordered f
 ### [Apache Iceberg 101 – Your Guide to Learning Apache Iceberg Concepts and Practices](https://www.dremio.com/subsurface/apache-iceberg-101-your-guide-to-learning-apache-iceberg-concepts-and-practices/)
 **Date**: September 12th, 2022, **Company**: Dremio
 
+

Review Comment:
   fixed



##########
landing-page/content/common/blogs.md:
##########
@@ -24,6 +24,24 @@ disableSidebar: true
 
 Here is a list of company blogs that talk about Iceberg. The blogs are ordered from most recent to oldest.
 
+### [Ensuring High Performance at Any Scale with Apache Iceberg’s Object Store File Layout](https://www.dremio.com/subsurface/ensuring-high-performance-at-any-scale-with-apache-icebergs-object-store-file-layout/)
+**Date**: September 20, 2022, **Company**: Dremio
+
+**Author**: [Alex Merced](https://www.linkedin.com/in/alexmerced/)

Review Comment:
   fixed



##########
landing-page/content/common/blogs.md:
##########
@@ -24,6 +24,24 @@ disableSidebar: true
 
 Here is a list of company blogs that talk about Iceberg. The blogs are ordered from most recent to oldest.
 
+### [Ensuring High Performance at Any Scale with Apache Iceberg’s Object Store File Layout](https://www.dremio.com/subsurface/ensuring-high-performance-at-any-scale-with-apache-icebergs-object-store-file-layout/)
+**Date**: September 20, 2022, **Company**: Dremio
+
+**Author**: [Alex Merced](https://www.linkedin.com/in/alexmerced/)
+### [Introduction to Apache Iceberg Using Spark](https://www.dremio.com/subsurface/introduction-to-apache-iceberg-using-spark/)
+**Date**: September 15, 2022, **Company**: Dremio
+
+**Author**: [Alex Merced](https://www.linkedin.com/in/alexmerced/)
+### [A Hands-On Look at the Structure of an Apache Iceberg Table](https://www.dremio.com/subsurface/a-hands-on-look-at-the-structure-of-an-apache-iceberg-table/)
+**Date**: August 24, 2022, **Company**: Dremio

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg-docs] gaborkaszab commented on pull request #149: blogs update (2 blogs from dremio)

Posted by GitBox <gi...@apache.org>.
gaborkaszab commented on PR #149:
URL: https://github.com/apache/iceberg-docs/pull/149#issuecomment-1246697500

   > > Could you please be a bit more specific in the commit message about what this patch holds? E.g. "Add 2 new blogs from Dremio" Other than that LGTM!
   > 
   > adjusted the name, anything else I need to do, or am I good and it will eventually get merged?
   
   Could you please do the same for the commit msg as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg-docs] AlexMercedCoder commented on pull request #149: blogs update (2 blogs from dremio)

Posted by GitBox <gi...@apache.org>.
AlexMercedCoder commented on PR #149:
URL: https://github.com/apache/iceberg-docs/pull/149#issuecomment-1245868897

   > Could you please be a bit more specific in the commit message about what this patch holds? E.g. "Add 2 new blogs from Dremio" Other than that LGTM!
   
   adjusted the name, anything else I need to do, or am I good and it will eventually get merged?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg-docs] Fokko merged pull request #149: blogs update (4 blogs from dremio)

Posted by GitBox <gi...@apache.org>.
Fokko merged PR #149:
URL: https://github.com/apache/iceberg-docs/pull/149


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg-docs] gaborkaszab commented on pull request #149: blogs update

Posted by GitBox <gi...@apache.org>.
gaborkaszab commented on PR #149:
URL: https://github.com/apache/iceberg-docs/pull/149#issuecomment-1229952921

   Could you please be a bit more specific in the commit message about what this patch holds? E.g. "Add 2 new blogs from Dremio"
   Other than that LGTM!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg-docs] gaborkaszab commented on a diff in pull request #149: blogs update (4 blogs from dremio)

Posted by GitBox <gi...@apache.org>.
gaborkaszab commented on code in PR #149:
URL: https://github.com/apache/iceberg-docs/pull/149#discussion_r979920245


##########
landing-page/content/common/blogs.md:
##########
@@ -24,6 +24,24 @@ disableSidebar: true
 
 Here is a list of company blogs that talk about Iceberg. The blogs are ordered from most recent to oldest.
 
+### [Ensuring High Performance at Any Scale with Apache Iceberg’s Object Store File Layout](https://www.dremio.com/subsurface/ensuring-high-performance-at-any-scale-with-apache-icebergs-object-store-file-layout/)
+**Date**: September 20, 2022, **Company**: Dremio
+
+**Author**: [Alex Merced](https://www.linkedin.com/in/alexmerced/)
+### [Introduction to Apache Iceberg Using Spark](https://www.dremio.com/subsurface/introduction-to-apache-iceberg-using-spark/)
+**Date**: September 15, 2022, **Company**: Dremio
+
+**Author**: [Alex Merced](https://www.linkedin.com/in/alexmerced/)
+### [A Hands-On Look at the Structure of an Apache Iceberg Table](https://www.dremio.com/subsurface/a-hands-on-look-at-the-structure-of-an-apache-iceberg-table/)
+**Date**: August 24, 2022, **Company**: Dremio

Review Comment:
   This (and the below) entry would break the ordering by date. Could you move these down to their place?



##########
landing-page/content/common/blogs.md:
##########
@@ -32,6 +50,7 @@ Here is a list of company blogs that talk about Iceberg. The blogs are ordered f
 ### [Apache Iceberg 101 – Your Guide to Learning Apache Iceberg Concepts and Practices](https://www.dremio.com/subsurface/apache-iceberg-101-your-guide-to-learning-apache-iceberg-concepts-and-practices/)
 **Date**: September 12th, 2022, **Company**: Dremio
 
+

Review Comment:
   This extra new line is not needed.



##########
landing-page/content/common/blogs.md:
##########
@@ -24,6 +24,24 @@ disableSidebar: true
 
 Here is a list of company blogs that talk about Iceberg. The blogs are ordered from most recent to oldest.
 
+### [Ensuring High Performance at Any Scale with Apache Iceberg’s Object Store File Layout](https://www.dremio.com/subsurface/ensuring-high-performance-at-any-scale-with-apache-icebergs-object-store-file-layout/)
+**Date**: September 20, 2022, **Company**: Dremio
+
+**Author**: [Alex Merced](https://www.linkedin.com/in/alexmerced/)

Review Comment:
   A linebreak is required after the author part. One more occasion of this below.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org