You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/05/06 13:30:42 UTC

[GitHub] [maven-gpg-plugin] bmarwell commented on a change in pull request #11: [MGPG-81] check format in constructor

bmarwell commented on a change in pull request #11:
URL: https://github.com/apache/maven-gpg-plugin/pull/11#discussion_r627420794



##########
File path: src/main/java/org/apache/maven/plugins/gpg/GpgVersion.java
##########
@@ -32,54 +32,46 @@
  */
 public class GpgVersion implements Comparable<GpgVersion>
 {
-    private final String rawVersion;
 
-    private GpgVersion( String rawVersion )
-    {
-        this.rawVersion = rawVersion;
-    }
+    private static final Pattern VERSION_PATTERN = Pattern.compile( "(\\d+\\.)+(\\d+)" );

Review comment:
       Works on mac, too: 
   ```
   $ gpgconf --query-swdb gnupg
   gnupg:2.2.21:-::32849:::::::
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org