You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/03 20:12:51 UTC
[GitHub] [airflow] ernest-kr opened a new pull request #12792: This table represents the list of all alembic revisions until 2.0.0
ernest-kr opened a new pull request #12792:
URL: https://github.com/apache/airflow/pull/12792
Created a table with the list of all alembic revisions until 2.0.0
Closes: #11989
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #12792: This table represents the list of all alembic revisions until 2.0.0
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #12792:
URL: https://github.com/apache/airflow/pull/12792#issuecomment-740200630
> > I think we need to exclude the doc from spell-check though @mik-laj @kaxil ? do you know how to do it ?
>
> Why do you want to exclude this file? I guess identifiers should simply be written as a code literal and then they won't be checked by spell check.
There's _a lot_ of identifiers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #12792: This table represents the list of all alembic revisions until 2.0.0
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #12792:
URL: https://github.com/apache/airflow/pull/12792#discussion_r537857908
##########
File path: docs/apache-airflow/alembic_revisions.rst
##########
@@ -0,0 +1,332 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+
+Alembic Revisions
+=================
+
+The following table shows the list of alembic revisions
+
+
+.. list-table:: Alembic Revisions(until Airflow 2.0.0):
+ :widths: 20 20 20 40
+ :header-rows: 1
+
+ * - Revision ID
+ - Revises ID
+ - Airflow Version
+ - Summary
+ * - e3a246e0dc1
+ - 1507a7289a2f
+ - 2.0.0
Review comment:
Did you want this to be a code literal, if so
```suggestion
- ``2.0.0``
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #12792: This table represents the list of all alembic revisions until 2.0.0
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #12792:
URL: https://github.com/apache/airflow/pull/12792#discussion_r538909517
##########
File path: docs/apache-airflow/alembic_revisions.rst
##########
@@ -0,0 +1,332 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+
+Alembic Revisions
+=================
+
+The following table shows the list of alembic revisions
+
+
+.. list-table:: Alembic Revisions(until Airflow 2.0.0):
+ :widths: 20 20 20 40
+ :header-rows: 1
+
+ * - Revision ID
+ - Revises ID
+ - Airflow Version
+ - Summary
+ * - e3a246e0dc1
+ - 1507a7289a2f
+ - 2.0.0
+ - create is_encrypted
+ * - 1507a7289a2f
+ - 13eb55f81627
+ - 2.0.0
+ - maintain history for compatibility with earlier migrations
+ * - 13eb55f81627
+ - 338e90f54d61
+ - 2.0.0
Review comment:
All the migrations have version `2.0.0` which is incorrect. If you check the example I have in https://github.com/apache/airflow/issues/11989 -- we want to show which migration was added in which Version example 1.10.10, 1.10.12 etc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #12792: This table represents the list of all alembic revisions until 2.0.0
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #12792:
URL: https://github.com/apache/airflow/pull/12792#issuecomment-738280613
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #12792: This table represents the list of all alembic revisions until 2.0.0
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #12792:
URL: https://github.com/apache/airflow/pull/12792#discussion_r537824617
##########
File path: docs/apache-airflow/alembic_revisions.rst
##########
@@ -0,0 +1,332 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+
+Alembic Revisions
+=================
+
+The following table shows the list of alembic revisions
+
+
+.. list-table:: Alembic Revisions(until Airflow 2.0.0):
+ :widths: 20 20 20 40
+ :header-rows: 1
+
+ * - Revision ID
+ - Revises ID
+ - Airflow Version
+ - Summary
+ * - e3a246e0dc1
+ - 1507a7289a2f
+ - 2.0.0
+ - create is_encrypted
Review comment:
```suggestion
- create `is_encrypted`
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ernest-kr commented on a change in pull request #12792: This table represents the list of all alembic revisions until 2.0.0
Posted by GitBox <gi...@apache.org>.
ernest-kr commented on a change in pull request #12792:
URL: https://github.com/apache/airflow/pull/12792#discussion_r537915141
##########
File path: docs/apache-airflow/alembic_revisions.rst
##########
@@ -0,0 +1,332 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+
+Alembic Revisions
+=================
+
+The following table shows the list of alembic revisions
+
+
+.. list-table:: Alembic Revisions(until Airflow 2.0.0):
Review comment:
Let me make these changes and modify my pull request
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #12792: This table represents the list of all alembic revisions until 2.0.0
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #12792:
URL: https://github.com/apache/airflow/pull/12792#discussion_r537659679
##########
File path: docs/apache-airflow/alembic_revisions.rst
##########
@@ -0,0 +1,328 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
Review comment:
We need to have it tomorrow @ernest-kr -> do you think you can automate it ? BTW. You will also have to include https://github.com/apache/airflow/pull/12890 when merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ernest-kr commented on a change in pull request #12792: This table represents the list of all alembic revisions until 2.0.0
Posted by GitBox <gi...@apache.org>.
ernest-kr commented on a change in pull request #12792:
URL: https://github.com/apache/airflow/pull/12792#discussion_r535717879
##########
File path: docs/apache-airflow/alembic_revisions.rst
##########
@@ -0,0 +1,328 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
Review comment:
Hi @mik-laj , I have not checked if we can generate this table automatically. Since we display them in the logs , I think there could be a way to generate them.
This is not added yet to the table of contents.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #12792: This table represents the list of all alembic revisions until 2.0.0
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #12792:
URL: https://github.com/apache/airflow/pull/12792#issuecomment-740202508
The orders (and down_revision) have changed after https://github.com/apache/airflow/pull/12896 was merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #12792: This table represents the list of all alembic revisions until 2.0.0
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #12792:
URL: https://github.com/apache/airflow/pull/12792#discussion_r537818892
##########
File path: docs/apache-airflow/alembic_revisions.rst
##########
@@ -0,0 +1,328 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
Review comment:
No problem. Will do :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #12792: This table represents the list of all alembic revisions until 2.0.0
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #12792:
URL: https://github.com/apache/airflow/pull/12792#discussion_r535579688
##########
File path: docs/apache-airflow/alembic_revisions.rst
##########
@@ -0,0 +1,328 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
Review comment:
This file wasn't added to the TOC. Am I right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #12792: This table represents the list of all alembic revisions until 2.0.0
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #12792:
URL: https://github.com/apache/airflow/pull/12792
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12792: This table represents the list of all alembic revisions until 2.0.0
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12792:
URL: https://github.com/apache/airflow/pull/12792#issuecomment-740170216
I think we need to exclude the doc from spell-check though @mik-laj @kaxil ? do you know how to do it ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #12792: This table represents the list of all alembic revisions until 2.0.0
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #12792:
URL: https://github.com/apache/airflow/pull/12792#discussion_r537348396
##########
File path: docs/apache-airflow/alembic_revisions.rst
##########
@@ -0,0 +1,328 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
Review comment:
I believe it is good to merge for RC1 as is @mik-laj -> we can automate it the first time we add a new migration. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #12792: This table represents the list of all alembic revisions until 2.0.0
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #12792:
URL: https://github.com/apache/airflow/pull/12792#discussion_r537824809
##########
File path: docs/apache-airflow/alembic_revisions.rst
##########
@@ -0,0 +1,332 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+
+Alembic Revisions
+=================
+
+The following table shows the list of alembic revisions
+
+
+.. list-table:: Alembic Revisions(until Airflow 2.0.0):
+ :widths: 20 20 20 40
+ :header-rows: 1
+
+ * - Revision ID
+ - Revises ID
+ - Airflow Version
+ - Summary
+ * - e3a246e0dc1
+ - 1507a7289a2f
+ - 2.0.0
+ - create is_encrypted
+ * - 1507a7289a2f
+ - 13eb55f81627
+ - 2.0.0
+ - maintain history for compatibility with earlier migrations
+ * - 13eb55f81627
+ - 338e90f54d61
+ - 2.0.0
+ - More logging into task_instance
+ * - 338e90f54d61
+ - 52d714495f0
+ - 2.0.0
+ - job_id indices
+ * - 52d714495f0
+ - 502898887f84
+ - 2.0.0
+ - Adding extra to Log
+ * - 502898887f84
+ - 1b38cef5b76e
+ - 2.0.0
+ - add dagrun
+ * - 1b38cef5b76e
+ - 2e541a1dcfed
+ - 2.0.0
+ - task_duration
+ * - 2e541a1dcfed
+ - 40e67319e3a9
+ - 2.0.0
+ - dagrun_config
+ * - 2e541a1dcfed
+ - 40e67319e3a9
+ - 2.0.0
+ - task_duration
+ * - 40e67319e3a9
+ - 561833c1c74b
+ - 2.0.0
+ - add password column to user
+ * - 561833c1c74b
+ - 4446e08588
+ - 2.0.0
+ - dagrun start end
+ * - 4446e08588
+ - bbc73705a13e
+ - 2.0.0
+ - Add notification_sent column to sla_miss
+ * - bbc73705a13e
+ - bba5a7cfc896
+ - 2.0.0
+ - Add a column to track the encryption state of the 'Extra' field in connection
+ * - bba5a7cfc896
+ - 1968acfc09e3
+ - 2.0.0
+ - add is_encrypted column to variable table
Review comment:
```suggestion
- add `is_encrypted` column to variable table
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #12792: This table represents the list of all alembic revisions until 2.0.0
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #12792:
URL: https://github.com/apache/airflow/pull/12792#discussion_r537824266
##########
File path: docs/apache-airflow/alembic_revisions.rst
##########
@@ -0,0 +1,332 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+
+Alembic Revisions
+=================
+
+The following table shows the list of alembic revisions
+
+
+.. list-table:: Alembic Revisions(until Airflow 2.0.0):
+ :widths: 20 20 20 40
+ :header-rows: 1
+
+ * - Revision ID
+ - Revises ID
+ - Airflow Version
+ - Summary
+ * - e3a246e0dc1
+ - 1507a7289a2f
+ - 2.0.0
Review comment:
```suggestion
- `2.0.0`
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #12792: This table represents the list of all alembic revisions until 2.0.0
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #12792:
URL: https://github.com/apache/airflow/pull/12792#discussion_r537859040
##########
File path: docs/apache-airflow/alembic_revisions.rst
##########
@@ -0,0 +1,332 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+
+Alembic Revisions
+=================
+
+The following table shows the list of alembic revisions
+
+
+.. list-table:: Alembic Revisions(until Airflow 2.0.0):
Review comment:
Is this just migrations since 1.10.14?
If so
```suggestion
.. list-table:: Alembic Revisions (from Airflow 2.0.0 onwards):
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #12792: This table represents the list of all alembic revisions until 2.0.0
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #12792:
URL: https://github.com/apache/airflow/pull/12792#discussion_r535579688
##########
File path: docs/apache-airflow/alembic_revisions.rst
##########
@@ -0,0 +1,328 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
Review comment:
I don't think this file was added to the TOC. Am I right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #12792: This table represents the list of all alembic revisions until 2.0.0
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #12792:
URL: https://github.com/apache/airflow/pull/12792#discussion_r537823998
##########
File path: docs/apache-airflow/alembic_revisions.rst
##########
@@ -0,0 +1,332 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+
+Alembic Revisions
+=================
+
+The following table shows the list of alembic revisions
+
+
+.. list-table:: Alembic Revisions(until Airflow 2.0.0):
+ :widths: 20 20 20 40
+ :header-rows: 1
+
+ * - Revision ID
+ - Revises ID
+ - Airflow Version
+ - Summary
+ * - e3a246e0dc1
+ - 1507a7289a2f
Review comment:
```suggestion
- `1507a7289a2f`
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #12792: This table represents the list of all alembic revisions until 2.0.0
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #12792:
URL: https://github.com/apache/airflow/pull/12792#discussion_r537579136
##########
File path: docs/apache-airflow/alembic_revisions.rst
##########
@@ -0,0 +1,328 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
Review comment:
We can merge this now, but I don't find it difficult to automate the generation of these tables.
Code that gets the migration list:
https://github.com/sqlalchemy/alembic/blob/master/alembic/command.py
Custom directives that render templates based on jinja:
https://github.com/apache/airflow/blob/master/docs/exts/operators_and_hooks_ref.py#L176-L205 + [`tabulate`](https://pypi.org/project/tabulate/) with rst output
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #12792: This table represents the list of all alembic revisions until 2.0.0
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #12792:
URL: https://github.com/apache/airflow/pull/12792#discussion_r537823826
##########
File path: docs/apache-airflow/alembic_revisions.rst
##########
@@ -0,0 +1,332 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+
+Alembic Revisions
+=================
+
+The following table shows the list of alembic revisions
+
+
+.. list-table:: Alembic Revisions(until Airflow 2.0.0):
+ :widths: 20 20 20 40
+ :header-rows: 1
+
+ * - Revision ID
+ - Revises ID
+ - Airflow Version
+ - Summary
+ * - e3a246e0dc1
Review comment:
```suggestion
* - `e3a246e0dc1`
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #12792: This table represents the list of all alembic revisions until 2.0.0
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #12792:
URL: https://github.com/apache/airflow/pull/12792#issuecomment-740172982
> I think we need to exclude the doc from spell-check though @mik-laj @kaxil ? do you know how to do it ?
Why do you want to exclude this file? I guess identifiers should simply be written as a code literal and then they won't be checked by spell check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12792: This table represents the list of all alembic revisions until 2.0.0
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12792:
URL: https://github.com/apache/airflow/pull/12792#issuecomment-787209763
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ernest-kr commented on a change in pull request #12792: This table represents the list of all alembic revisions until 2.0.0
Posted by GitBox <gi...@apache.org>.
ernest-kr commented on a change in pull request #12792:
URL: https://github.com/apache/airflow/pull/12792#discussion_r537721494
##########
File path: docs/apache-airflow/alembic_revisions.rst
##########
@@ -0,0 +1,328 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
Review comment:
Hi , Unfortunately I do not have time to finish by tomorrow on this. Can you create a new issue for the automate task so I can work on it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #12792: This table represents the list of all alembic revisions until 2.0.0
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #12792:
URL: https://github.com/apache/airflow/pull/12792#issuecomment-738291363
@ernest-kr Do you think we can generate these tables automatically?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org