You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/08/20 06:14:08 UTC
[GitHub] [yunikorn-k8shim] HuangTing-Yao opened a new pull request, #451: [YUNIKORN-1122]Move constants to scheduler interface
HuangTing-Yao opened a new pull request, #451:
URL: https://github.com/apache/yunikorn-k8shim/pull/451
### What is this PR for?
leverage constant from si repo
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1122
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] pbacsko closed pull request #451: [YUNIKORN-1122]Move constants to scheduler interface
Posted by GitBox <gi...@apache.org>.
pbacsko closed pull request #451: [YUNIKORN-1122]Move constants to scheduler interface
URL: https://github.com/apache/yunikorn-k8shim/pull/451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #451: [YUNIKORN-1122]Move constants to scheduler interface
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #451:
URL: https://github.com/apache/yunikorn-k8shim/pull/451#issuecomment-1221242743
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/451?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#451](https://codecov.io/gh/apache/yunikorn-k8shim/pull/451?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (59ceead) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/135b3b57f84ffccdb7296d0ca83c88ba4687fa91?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (135b3b5) will **not change** coverage.
> The diff coverage is `88.88%`.
```diff
@@ Coverage Diff @@
## master #451 +/- ##
=======================================
Coverage 67.24% 67.24%
=======================================
Files 41 41
Lines 6722 6722
=======================================
Hits 4520 4520
Misses 2032 2032
Partials 170 170
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/451?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/common/resource.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yZXNvdXJjZS5nbw==) | `94.30% <80.00%> (ø)` | |
| [pkg/appmgmt/general/metadata.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FwcG1nbXQvZ2VuZXJhbC9tZXRhZGF0YS5nbw==) | `84.05% <100.00%> (ø)` | |
| [pkg/cache/context.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `44.96% <100.00%> (ø)` | |
| [pkg/common/si\_helper.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zaV9oZWxwZXIuZ28=) | `97.53% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org