You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2015/02/04 13:44:38 UTC
Review Request 30613: CLOUDSTACK-8211: Correcting expected secondary
storage
count value by rounding off to floor value and including the physicalsize
of snapshot
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30613/
-----------------------------------------------------------
Review request for cloudstack, Anshul Gangwar and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-8211
https://issues.apache.org/jira/browse/CLOUDSTACK-8211
Repository: cloudstack-git
Description
-------
The expected secondary storage count needs to rounded off to integer floor. Also the physicalsize of the snapshot needs to be included in the expected count.
Diffs
-----
test/integration/component/test_ss_limits.py 8662cd5
Diff: https://reviews.apache.org/r/30613/diff/
Testing
-------
Test register template ... SKIP: skip
Test register template ... SKIP: skip
Test create snapshot and templates from volume ... === TestName: test_02_create_template_snapshot_1_root_domain_admin | Status :
SUCCESS ===
ok
Test create snapshot and templates from volume ... === TestName: test_02_create_template_snapshot_2_child_domain_admin | Status :
SUCCESS ===
ok
Test register iso ... SKIP: skip
Test register iso ... SKIP: skip
Test copy template between zones ... SKIP: skip
Test copy template between zones ... SKIP: skip
----------------------------------------------------------------------
Ran 8 tests in 685.637s
OK (SKIP=6)
~
Thanks,
Gaurav Aradhye
Re: Review Request 30613: CLOUDSTACK-8211: Correcting expected
secondary
storage count value by rounding off to floor value and including the
physicalsize of snapshot
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30613/#review71196
-----------------------------------------------------------
Ship it!
a4e9b4e8a4e6bdcec8ad1cda0435f8c61589576f master
- SrikanteswaraRao Talluri
On Feb. 4, 2015, 12:44 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30613/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 12:44 p.m.)
>
>
> Review request for cloudstack, Anshul Gangwar and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-8211
> https://issues.apache.org/jira/browse/CLOUDSTACK-8211
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The expected secondary storage count needs to rounded off to integer floor. Also the physicalsize of the snapshot needs to be included in the expected count.
>
>
> Diffs
> -----
>
> test/integration/component/test_ss_limits.py 8662cd5
>
> Diff: https://reviews.apache.org/r/30613/diff/
>
>
> Testing
> -------
>
> Test register template ... SKIP: skip
> Test register template ... SKIP: skip
> Test create snapshot and templates from volume ... === TestName: test_02_create_template_snapshot_1_root_domain_admin | Status :
> SUCCESS ===
> ok
> Test create snapshot and templates from volume ... === TestName: test_02_create_template_snapshot_2_child_domain_admin | Status :
> SUCCESS ===
> ok
> Test register iso ... SKIP: skip
> Test register iso ... SKIP: skip
> Test copy template between zones ... SKIP: skip
> Test copy template between zones ... SKIP: skip
>
> ----------------------------------------------------------------------
> Ran 8 tests in 685.637s
>
> OK (SKIP=6)
> ~
>
>
> Thanks,
>
> Gaurav Aradhye
>
>