You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "John Hjelmstad (JIRA)" <ji...@apache.org> on 2008/09/11 01:12:44 UTC
[jira] Created: (SHINDIG-586) Avoid repeated checksum generation
for cached HttpResponses by storing checksum in HttpResponse object.
Avoid repeated checksum generation for cached HttpResponses by storing checksum in HttpResponse object.
-------------------------------------------------------------------------------------------------------
Key: SHINDIG-586
URL: https://issues.apache.org/jira/browse/SHINDIG-586
Project: Shindig
Issue Type: Improvement
Components: Gadget Rendering Server (Java)
Reporter: John Hjelmstad
CachingContentRewriterRegistry uses checksums to generate rewritten-content cache keys. In the case of HttpResponse rewriting, in practice the vast majority of rewrites - and rewritten content cache lookups - are made using cached HttpResponse objects.
To avoid recomputing checksum for each of these requests simply to look up, we can store checksum as a special header on HttpResponse (which is not serialized on output) before caching it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-586) Avoid repeated checksum generation
for cached HttpResponses by storing checksum in HttpResponse object.
Posted by "John Hjelmstad (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630032#action_12630032 ]
John Hjelmstad commented on SHINDIG-586:
----------------------------------------
Missed the obvious point that headers is an unmodifiable map... discussion on shindig-dev.
> Avoid repeated checksum generation for cached HttpResponses by storing checksum in HttpResponse object.
> -------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-586
> URL: https://issues.apache.org/jira/browse/SHINDIG-586
> Project: Shindig
> Issue Type: Improvement
> Components: Gadget Rendering Server (Java)
> Reporter: John Hjelmstad
> Assignee: John Hjelmstad
>
> CachingContentRewriterRegistry uses checksums to generate rewritten-content cache keys. In the case of HttpResponse rewriting, in practice the vast majority of rewrites - and rewritten content cache lookups - are made using cached HttpResponse objects.
> To avoid recomputing checksum for each of these requests simply to look up, we can store checksum as a special header on HttpResponse (which is not serialized on output) before caching it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SHINDIG-586) Avoid repeated checksum generation for
cached HttpResponses by storing checksum in HttpResponse object.
Posted by "John Hjelmstad (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Hjelmstad closed SHINDIG-586.
----------------------------------
Resolution: Later
Too big a pain right now. The side effects associated with storing checksum in headers would require that .equals() changes to ignore that particular header, toString() doesn't emit it, etc. To get these right would be more costly than it's worth right now. I created a patch for this (which I'll attach for posterity), but will not be applying it.
> Avoid repeated checksum generation for cached HttpResponses by storing checksum in HttpResponse object.
> -------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-586
> URL: https://issues.apache.org/jira/browse/SHINDIG-586
> Project: Shindig
> Issue Type: Improvement
> Components: Gadget Rendering Server (Java)
> Reporter: John Hjelmstad
> Assignee: John Hjelmstad
>
> CachingContentRewriterRegistry uses checksums to generate rewritten-content cache keys. In the case of HttpResponse rewriting, in practice the vast majority of rewrites - and rewritten content cache lookups - are made using cached HttpResponse objects.
> To avoid recomputing checksum for each of these requests simply to look up, we can store checksum as a special header on HttpResponse (which is not serialized on output) before caching it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SHINDIG-586) Avoid repeated checksum generation
for cached HttpResponses by storing checksum in HttpResponse object.
Posted by "John Hjelmstad (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Hjelmstad reassigned SHINDIG-586:
--------------------------------------
Assignee: John Hjelmstad
> Avoid repeated checksum generation for cached HttpResponses by storing checksum in HttpResponse object.
> -------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-586
> URL: https://issues.apache.org/jira/browse/SHINDIG-586
> Project: Shindig
> Issue Type: Improvement
> Components: Gadget Rendering Server (Java)
> Reporter: John Hjelmstad
> Assignee: John Hjelmstad
>
> CachingContentRewriterRegistry uses checksums to generate rewritten-content cache keys. In the case of HttpResponse rewriting, in practice the vast majority of rewrites - and rewritten content cache lookups - are made using cached HttpResponse objects.
> To avoid recomputing checksum for each of these requests simply to look up, we can store checksum as a special header on HttpResponse (which is not serialized on output) before caching it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.