You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Ezequiel Torres <ez...@gmail.com> on 2018/06/27 14:28:14 UTC
Review Request 67757: TaskQuery struct needs to be optional
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67757/
-----------------------------------------------------------
Review request for Aurora.
Repository: aurora
Description
-------
In languages like Go, types are not optionals by default.
The actual api.thift don't let create queries with just a
few fields in Go since all the fields are required
Diffs
-----
api/src/main/thrift/org/apache/aurora/gen/api.thrift 7265b11103aa12743c42355163ae64e98e965d7f
Diff: https://reviews.apache.org/r/67757/diff/1/
Testing
-------
Thanks,
Ezequiel Torres
Re: Review Request 67757: TaskQuery struct needs to be optional
Posted by Renan DelValle <re...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67757/#review205464
-----------------------------------------------------------
Ship it!
Ship It!
- Renan DelValle
On June 27, 2018, 9:18 a.m., Ezequiel Torres wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67757/
> -----------------------------------------------------------
>
> (Updated June 27, 2018, 9:18 a.m.)
>
>
> Review request for Aurora.
>
>
> Bugs: https://issues.apache.org/jira/browse/AURORA-1991
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AURORA-1991
>
>
> Repository: aurora
>
>
> Description
> -------
>
> In languages like Go, types are not optionals by default.
> The actual api.thift don't let create queries with just a
> few fields in Go since all the fields are required
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 7265b11103aa12743c42355163ae64e98e965d7f
>
>
> Diff: https://reviews.apache.org/r/67757/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ezequiel Torres
>
>
Re: Review Request 67757: TaskQuery struct needs to be optional
Posted by Ezequiel Torres <ez...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67757/
-----------------------------------------------------------
(Updated June 27, 2018, 4:18 p.m.)
Review request for Aurora.
Bugs: https://issues.apache.org/jira/browse/AURORA-1991
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AURORA-1991
Repository: aurora
Description
-------
In languages like Go, types are not optionals by default.
The actual api.thift don't let create queries with just a
few fields in Go since all the fields are required
Diffs
-----
api/src/main/thrift/org/apache/aurora/gen/api.thrift 7265b11103aa12743c42355163ae64e98e965d7f
Diff: https://reviews.apache.org/r/67757/diff/1/
Testing
-------
Thanks,
Ezequiel Torres
Re: Review Request 67757: TaskQuery struct needs to be optional
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67757/#review205440
-----------------------------------------------------------
Ship it!
Master (5e5bcbc) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 27, 2018, 2:28 p.m., Ezequiel Torres wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67757/
> -----------------------------------------------------------
>
> (Updated June 27, 2018, 2:28 p.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> In languages like Go, types are not optionals by default.
> The actual api.thift don't let create queries with just a
> few fields in Go since all the fields are required
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 7265b11103aa12743c42355163ae64e98e965d7f
>
>
> Diff: https://reviews.apache.org/r/67757/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ezequiel Torres
>
>